-
Notifications
You must be signed in to change notification settings - Fork 566
chore: Reexport module profiler
#4535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @zen-xu thanks for fixing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I think those imports are not necessary
|
@zen-xu i took the liberty to update your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4535 +/- ##
==========================================
+ Coverage 84.53% 84.56% +0.03%
==========================================
Files 158 158
Lines 16490 16491 +1
Branches 2856 2856
==========================================
+ Hits 13940 13946 +6
+ Misses 1702 1700 -2
+ Partials 848 845 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it is good to go
The example provided by sentry causes pylance to report
"profiler" is not a known attribute of module "sentry_sdk"