Skip to content

Conversation

@zen-xu
Copy link
Contributor

@zen-xu zen-xu commented Jun 30, 2025

The example provided by sentry causes pylance to report "profiler" is not a known attribute of module "sentry_sdk"

image

@zen-xu zen-xu requested a review from a team as a code owner June 30, 2025 03:08
@antonpirker
Copy link
Contributor

Hey @zen-xu thanks for fixing this!
Why is the from sentry_sdk import integrations, logger in your PR? Is this on purpose?

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. I think those imports are not necessary

@antonpirker
Copy link
Contributor

@zen-xu i took the liberty to update your PR.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.56%. Comparing base (b19e086) to head (dcd1305).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4535      +/-   ##
==========================================
+ Coverage   84.53%   84.56%   +0.03%     
==========================================
  Files         158      158              
  Lines       16490    16491       +1     
  Branches     2856     2856              
==========================================
+ Hits        13940    13946       +6     
+ Misses       1702     1700       -2     
+ Partials      848      845       -3     
Files with missing lines Coverage Δ
sentry_sdk/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is good to go

@antonpirker antonpirker merged commit 5a122b5 into getsentry:master Sep 12, 2025
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants