toxgen: Detect correct sentry-sdk #4558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes after switching branches, importlib.metadata(sentry-sdk) would point to the wrong metadata (SDK 2.x instead of 3.x), which in turn meant toxgen would think the SDK supports different Python versions than it should.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4558 +/- ##
==========================================
- Coverage 80.70% 80.68% -0.02%
==========================================
Files 156 156
Lines 16482 16482
Branches 2802 2802
==========================================
- Hits 13301 13299 -2
- Misses 2297 2299 +2
Partials 884 884 |
antonpirker
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes after switching branches,
importlib.metadata("sentry-sdk")would point to the wrong metadata (SDK 2.x instead of 3.x), which in turn meant toxgen would think the SDK supports different Python versions than it should.Closes #4556