-
Notifications
You must be signed in to change notification settings - Fork 569
Fix importlib test logic #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importlib test logic #4592
Conversation
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also just investigating this test failure; imo the test is basically pointless. I raised a PR to delete it: #4593.
But, if you'd rather keep the test around that is fine; your changes seem reasonable, so I will approve.
2a6b90b to
2f6982e
Compare
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
No description provided.