Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 22, 2025

Just an experiment to see how badly things are broken.

Failing test:

=================================== FAILURES ===================================
_________________________ test_databag_depth_stripping _________________________
tests/test_client.py:754: in test_databag_depth_stripping
    @benchmark
     ^^^^^^^^^
tests/conftest.py:66: in <lambda>
    return lambda x: x()
                     ^^^
tests/test_client.py:765: in inner
    assert len(json.dumps(event)) < 10000
E   assert 202658 < 10000
E    +  where 202658 = len('{"level": "error", "exception": {"values": [{"mechanism": {"type": "generic", "handled": true}, "module": null, "type": "ZeroDivisionError", "value": "division by zero", "stacktrace": {"frames": [{"filename": "tests/test_client.py", "abs_path": "/home/runner/work/sentry-python/sentry-python/tests/test_client.py", "function": "inner", "module": "tests.test_client", "lineno": 759, "pre_context": ["    @benchmark", "    def inner():", "        del events[:]", "        try:", "            a = value  # noqa"], "context_line": "            1 / 0", "post_context": ["        except Exception:", "            capture_exception()", "", "        (event,) = events", ""], "vars": {"a": [[[["[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[
E    +    where '{"level": "error", "exception": {"values": [{"mechanism": {"type": "generic", "handled": true}, "module": null, "type": "ZeroDivisionError", "value": "division by zero", "stacktrace": {"frames": [{"filename": "tests/test_client.py", "abs_path": "/home/runner/work/sentry-python/sentry-python/tests/test_client.py", "function": "inner", "module": "tests.test_client", "lineno": 759, "pre_context": ["    @benchmark", "    def inner():", "        del events[:]", "        try:", "            a = value  # noqa"], "context_line": "            1 / 0", "post_context": ["        except Exception:", "            capture_exception()", "", "        (event,) = events", ""], "vars": {"a": [[[["[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[
E    +      where <function dumps at 0x7f1ff66ed900> = json.dumps

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.70%. Comparing base (493ac4b) to head (be6aa64).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4608      +/-   ##
==========================================
- Coverage   80.75%   80.70%   -0.06%     
==========================================
  Files         156      156              
  Lines       16636    16636              
  Branches     2831     2831              
==========================================
- Hits        13435    13426       -9     
- Misses       2312     2318       +6     
- Partials      889      892       +3     

see 2 files with indirect coverage changes

@sentrivana sentrivana closed this Sep 12, 2025
@sentrivana sentrivana deleted the ivana/3.14-rc1 branch October 20, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants