Skip to content

Conversation

@sl0thentr0py
Copy link
Member

closes #4606

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner July 24, 2025 12:12
@codecov
Copy link

codecov bot commented Jul 24, 2025

❌ 32 Tests Failed:

Tests completed Failed Passed Skipped
22963 32 22931 2100
View the top 3 failed test(s) by shortest run time
tests.integrations.django.test_basic::test_rest_framework_basic[application/json-1-rest_framework_exc]
Stack Traces | 0.08s run time
.../integrations/django/test_basic.py:913: in test_rest_framework_basic
    assert event["request"]["data"] == body
E   KeyError: 'data'
tests.integrations.django.test_basic::test_rest_framework_basic[application/json-foo-rest_framework_exc]
Stack Traces | 0.081s run time
.../integrations/django/test_basic.py:913: in test_rest_framework_basic
    assert event["request"]["data"] == body
E   KeyError: 'data'
tests.integrations.django.test_basic::test_rest_framework_basic[application/x-www-form-urlencoded-body3-rest_framework_exc]
Stack Traces | 0.084s run time
.../integrations/django/test_basic.py:913: in test_rest_framework_basic
    assert event["request"]["data"] == body
E   KeyError: 'data'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sl0thentr0py sl0thentr0py force-pushed the neel/generalize-serialize-iterable branch from ca1a5bb to 2508e4f Compare July 24, 2025 12:16
@sl0thentr0py sl0thentr0py marked this pull request as draft July 24, 2025 12:17
@sl0thentr0py sl0thentr0py force-pushed the neel/generalize-serialize-iterable branch from 2508e4f to 18bcc19 Compare July 24, 2025 12:17
@sl0thentr0py
Copy link
Member Author

sl0thentr0py commented Jul 24, 2025

WSGIRequest itself has an __iter__ so this is not a good idea, closing. Will make a less general solution.

https://github.com/django/django/blob/22506b2c162b34c4c45f748cf11ede75824a40cd/django/http/request.py#L477-L478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip Queryset serialization for any querysets embedded in the stack frame f_locals.

2 participants