Generate minimal sentry-python reproduction #4662
Closed
+549
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: daniel.szoke <[email protected]>
Contributor
|
@szokeasaurusrex can this PR be closed? |
Member
Author
|
Closed, thanks @antonpirker! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4662 +/- ##
==========================================
- Coverage 85.09% 85.03% -0.06%
==========================================
Files 156 156
Lines 15797 15797
Branches 2671 2671
==========================================
- Hits 13442 13433 -9
- Misses 1578 1589 +11
+ Partials 777 775 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a minimal reproduction for issue #4657, where the
clickhouse-driverintegration prematurely consumes generators whensend_default_piiis enabled.The reproduction includes:
simple_reproduce.py: A clear demonstration of the generator consumption.reproduce_issue.py: A comprehensive script showing behavior with and without Sentry.test_generator_issue.py: A pytest-compatible test case to verify the fix.README.md: Instructions and details on the bug's location.Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.
Learn more about Cursor Agents