Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 6, 2025

Closes #4270

@codecov
Copy link

codecov bot commented Aug 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
22400 1 22399 2098
View the top 1 failed test(s) by shortest run time
tests.integrations.redis.test_redis_cache_module::test_key_as_string[key7-]
Stack Traces | 0.002s run time
.../integrations/redis/test_redis_cache_module.py:318: in test_key_as_string
    assert _key_as_string(key) == expected_key
E   AssertionError: assert 'Y\x11¨ŀGεiF*,:4M' == ''
E     + Y#x11¨ŀGεiF*,:4M

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana changed the title Remove Decimal Use float for sample rand Aug 6, 2025
@sentrivana sentrivana marked this pull request as ready for review August 7, 2025 11:14
@sentrivana sentrivana requested a review from a team as a code owner August 7, 2025 11:14
@sentrivana sentrivana changed the base branch from ivana/random-perf-improvements to master August 7, 2025 14:30
@sentrivana sentrivana marked this pull request as draft August 12, 2025 11:31
cursor[bot]

This comment was marked as outdated.

@sentrivana sentrivana marked this pull request as ready for review August 14, 2025 12:34
@sentrivana sentrivana changed the title Use float for sample rand ref(tracing): Use float for sample rand Aug 14, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for cleaning this up!

@antonpirker antonpirker enabled auto-merge (squash) September 11, 2025 15:00
@antonpirker antonpirker merged commit 007058d into master Sep 12, 2025
137 of 140 checks passed
@antonpirker antonpirker deleted the ivana/remove-decimal branch September 12, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move away from Decimal

2 participants