Skip to content

Use context for logging extra #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: potel-base
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 12, 2025

We're moving away from using extra on the event in favor of contexts

Ref #4687

Copy link

codecov bot commented Aug 12, 2025

❌ 28 Tests Failed:

Tests completed Failed Passed Skipped
20832 28 20804 1098
View the top 3 failed test(s) by shortest run time
tests.integrations.redis.test_redis::test_redis_pipeline[True-True-expected_first_ten1]
Stack Traces | 0.085s run time
.../integrations/redis/test_redis.py:62: in test_redis_pipeline
    connection = FakeStrictRedis()
.tox/py3.11-redis-v4/lib/python3.11.../site-packages/fakeredis/_connection.py:185: in __init__
    super().__init__(**kwds)
E   TypeError: Redis.__init__() got an unexpected keyword argument 'lib_name'
tests.test_scrubber::test_breadcrumb_extra_scrubbing
Stack Traces | 0.085s run time
tests/test_scrubber.py:135: in test_breadcrumb_extra_scrubbing
    assert event["extra"]["bar"] == 69
E   KeyError: 'bar'
tests.integrations.redis.test_redis_cache_module::test_cache_data
Stack Traces | 0.086s run time
.../integrations/redis/test_redis_cache_module.py:125: in test_cache_data
    connection = FakeStrictRedis(host="mycacheserver.io", port=6378)
.tox/py3.11-redis-v4/lib/python3.11.../site-packages/fakeredis/_connection.py:185: in __init__
    super().__init__(**kwds)
E   TypeError: Redis.__init__() got an unexpected keyword argument 'lib_name'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant