Skip to content

Conversation

@antonpirker
Copy link
Contributor

should now have everything it needs.

@antonpirker antonpirker requested a review from a team as a code owner August 13, 2025 12:23
kwargs.get("parent_run_id"),
op=OP.GEN_AI_EXECUTE_TOOL,
name=serialized.get("name") or kwargs.get("name") or "AI tool usage",
name=f"execute_tool {tool_name}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Tool Execution Span Naming Regression

The on_tool_start span name now incorrectly displays "execute_tool None" when serialized.get("name") and kwargs.get("name") are both falsy. This regression removes the previous fallback to "AI tool usage", resulting in unhelpful span names.

Fix in Cursor Fix in Web

@codecov
Copy link

codecov bot commented Aug 13, 2025

❌ 32 Tests Failed:

Tests completed Failed Passed Skipped
20366 32 20334 1898
View the top 3 failed test(s) by shortest run time
tests.integrations.redis.test_redis::test_span_origin
Stack Traces | 0.074s run time
.../integrations/redis/test_redis.py:305: in test_span_origin
    connection = FakeStrictRedis()
.tox/py3.11-redis-v4/lib/python3.11.../site-packages/fakeredis/_connection.py:185: in __init__
    super().__init__(**kwds)
E   TypeError: Redis.__init__() got an unexpected keyword argument 'lib_name'
tests.integrations.redis.test_redis_cache_module::test_cache_keys
Stack Traces | 0.074s run time
.../integrations/redis/test_redis_cache_module.py:91: in test_cache_keys
    connection = FakeStrictRedis()
.tox/py3.11-redis-v4/lib/python3.11.../site-packages/fakeredis/_connection.py:185: in __init__
    super().__init__(**kwds)
E   TypeError: Redis.__init__() got an unexpected keyword argument 'lib_name'
tests.integrations.redis.test_redis::test_pii_data_redacted
Stack Traces | 0.075s run time
.../integrations/redis/test_redis.py:117: in test_pii_data_redacted
    connection = FakeStrictRedis()
.tox/py3.11-redis-v4/lib/python3.11.../site-packages/fakeredis/_connection.py:185: in __init__
    super().__init__(**kwds)
E   TypeError: Redis.__init__() got an unexpected keyword argument 'lib_name'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker merged commit 6c0d172 into shellmayr/feat/langchain-integration-update Aug 13, 2025
116 of 125 checks passed
@antonpirker antonpirker deleted the antonpirker/langchain1 branch August 13, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants