Skip to content

Conversation

@mgaligniana
Copy link
Contributor

Fixes: GH-3516

@mgaligniana mgaligniana requested a review from a team as a code owner August 18, 2025 03:37
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.91%. Comparing base (e012ff1) to head (47d563c).
⚠️ Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
sentry_sdk/integrations/wsgi.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4708      +/-   ##
==========================================
+ Coverage   84.87%   84.91%   +0.04%     
==========================================
  Files         156      155       -1     
  Lines       16109    16090      -19     
  Branches     2740     2732       -8     
==========================================
- Hits        13672    13663       -9     
+ Misses       1650     1643       -7     
+ Partials      787      784       -3     
Files with missing lines Coverage Δ
sentry_sdk/integrations/wsgi.py 94.85% <80.00%> (-1.25%) ⬇️

... and 2 files with indirect coverage changes

@antonpirker
Copy link
Contributor

Hey @mgaligniana thanks for your PR!

Unfortunately we can not merge this, because it would introduce Werkzeug as a dependency for our SDK and we do not add new dependencies. We want to have a minimal amount of dependencies in the SDK.

This is why I will close this PR.

What you could do: You could vendor in a newer version of Werkzeug if this makes WSGI integration better or easier to maintain.

@mgaligniana
Copy link
Contributor Author

@antonpirker Perfect, no problem! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if we still need _werkzeug.py

2 participants