tests: Trigger Pytest failure when an unraisable exception occurs #4738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-alderman-webb
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4738 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 156 156
Lines 16115 16115
Branches 2741 2741
=======================================
+ Hits 13685 13686 +1
Misses 1643 1643
+ Partials 787 786 -1 |
sentrivana
approved these changes
Sep 2, 2025
alexander-alderman-webb
deleted the
webb/error-on-unraisable-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test you can revert changes in #4736, or just flip the
manual_span_cleanupargument. The OpenAI tests should then fail.Closes #4723.
Closes PY-1816.