Skip to content

Conversation

@vmarkovtsev
Copy link
Contributor

@vmarkovtsev vmarkovtsev commented Sep 2, 2025

If a coroutine exits an async loop by raising AsyncStopIteration, Sentry reports it as an error. There is no error in that case.

…gration

If a coroutine exits an async loop by raising AsyncStopIteration, Sentry reports it as an error. There is no error in that case.
@vmarkovtsev vmarkovtsev requested a review from a team as a code owner September 2, 2025 14:50
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

@antonpirker antonpirker enabled auto-merge (squash) September 11, 2025 14:25
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.57%. Comparing base (18d3899) to head (910c8c9).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sentry_sdk/integrations/asyncio.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4741   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files         158      158           
  Lines       16480    16482    +2     
  Branches     2855     2856    +1     
=======================================
+ Hits        13938    13940    +2     
- Misses       1695     1696    +1     
+ Partials      847      846    -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/asyncio.py 86.44% <50.00%> (-1.28%) ⬇️

... and 1 file with indirect coverage changes

@antonpirker antonpirker merged commit dcefe38 into getsentry:master Sep 11, 2025
127 of 128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants