Skip to content

Conversation

alexander-alderman-webb
Copy link
Contributor

The following code snippet now fails mypy: #4663 (comment)

I followed how other functions in the SDK are typed. For example, other wrappers have the signature (F) -> F for a type variable F, although here the function can be async as well.

Closes #4663

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner September 3, 2025 07:19
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (4456351) to head (27c5c53).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4745      +/-   ##
==========================================
- Coverage   84.88%   84.85%   -0.03%     
==========================================
  Files         156      156              
  Lines       16115    16115              
  Branches     2741     2741              
==========================================
- Hits        13679    13675       -4     
- Misses       1650     1652       +2     
- Partials      786      788       +2     
Files with missing lines Coverage Δ
sentry_sdk/ai/monitoring.py 85.33% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@alexander-alderman-webb alexander-alderman-webb merged commit f702ec9 into master Sep 3, 2025
135 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/type-ai-track-decorator branch September 3, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ai_track decorator hides mypy errors and blocks propagation of errors in traces
2 participants