-
Notifications
You must be signed in to change notification settings - Fork 566
Update HuggingFace Hub integration #4746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4746 +/- ##
==========================================
- Coverage 84.55% 84.53% -0.03%
==========================================
Files 158 158
Lines 16379 16457 +78
Branches 2809 2848 +39
==========================================
+ Hits 13850 13912 +62
- Misses 1699 1700 +1
- Partials 830 845 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rewritten the tests from scratch. Dont look at the diff, just the full new file.
Make our existing
huggingface_hubintegration compatible with the new AI Agents insights module.All spans created by the integrations should should create all spans applicable form the AI Insights documentation.
All spans must have the correct span.op, span.name/span.description and span.data/span.attributes set.
This makes our SDK and data compatible with v1.36.0 of the Semantic conventions for generative AI systems of OpenTelementry.
There are some cases where our AI Insights documentation diverges from Otels semantic conventions. Details for those attributes can be found in the Sentry conventions.