Skip to content

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Sep 3, 2025

Make our existing huggingface_hub integration compatible with the new AI Agents insights module.

All spans created by the integrations should should create all spans applicable form the AI Insights documentation.

All spans must have the correct span.op, span.name/span.description and span.data/span.attributes set.

This makes our SDK and data compatible with v1.36.0 of the Semantic conventions for generative AI systems of OpenTelementry.

There are some cases where our AI Insights documentation diverges from Otels semantic conventions. Details for those attributes can be found in the Sentry conventions.

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 83.06452% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.53%. Comparing base (ca1a898) to head (2209c6f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sentry_sdk/integrations/huggingface_hub.py 82.92% 3 Missing and 18 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4746      +/-   ##
==========================================
- Coverage   84.55%   84.53%   -0.03%     
==========================================
  Files         158      158              
  Lines       16379    16457      +78     
  Branches     2809     2848      +39     
==========================================
+ Hits        13850    13912      +62     
- Misses       1699     1700       +1     
- Partials      830      845      +15     
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.33% <100.00%> (+<0.01%) ⬆️
sentry_sdk/integrations/__init__.py 87.01% <ø> (ø)
sentry_sdk/integrations/huggingface_hub.py 85.22% <82.92%> (+1.38%) ⬆️

... and 1 file with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review September 9, 2025 13:26
@antonpirker antonpirker requested a review from a team as a code owner September 9, 2025 13:26
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rewritten the tests from scratch. Dont look at the diff, just the full new file.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@antonpirker antonpirker merged commit 9001126 into master Sep 10, 2025
127 of 128 checks passed
@antonpirker antonpirker deleted the antonpirker/huggingface-hub-update branch September 10, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants