-
Notifications
You must be signed in to change notification settings - Fork 556
tests: Move asyncpg under toxgen #4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4757 +/- ##
=======================================
Coverage 84.76% 84.77%
=======================================
Files 158 158
Lines 16323 16323
Branches 2792 2792
=======================================
+ Hits 13837 13838 +1
+ Misses 1671 1670 -1
Partials 815 815 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Tox Environment Mismatch in CI
The CI workflow attempts to run py${{ matrix.python-version }}-asyncpg-latest
tests. However, the asyncpg-latest
tox environment no longer exists after migrating to auto-generated toxgen
configuration, which only creates specific versioned targets. This causes the CI job to fail.
.github/workflows/test-integrations-dbs.yml#L70-L79
sentry-python/.github/workflows/test-integrations-dbs.yml
Lines 70 to 79 in 84328bd
- name: Erase coverage | |
run: | | |
coverage erase | |
- name: Test asyncpg latest | |
run: | | |
set -x # print commands that are executed | |
./scripts/runtox.sh "py${{ matrix.python-version }}-asyncpg-latest" | |
- name: Test clickhouse_driver latest | |
run: | | |
set -x # print commands that are executed |
.github/workflows/test-integrations-dbs.yml#L94-L97
sentry-python/.github/workflows/test-integrations-dbs.yml
Lines 94 to 97 in 84328bd
run: | | |
set -x # print commands that are executed | |
./scripts/runtox.sh "py${{ matrix.python-version }}-sqlalchemy-latest" | |
- name: Generate coverage XML (Python 3.6) |
Ref #4506