-
Notifications
You must be signed in to change notification settings - Fork 565
tests: Move httpx under toxgen #4780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4c02bdf
move gcp
sentrivana 841a3d5
tests: Move httpx under toxgen
sentrivana dbef4f9
.
sentrivana d539a27
.
sentrivana 19ec9f3
.
sentrivana d8a73f7
.
sentrivana d34403b
Merge branch 'master' into ivana/toxgen/httpx
sentrivana 762a233
.
sentrivana f0de66b
Merge branch 'master' into ivana/toxgen/httpx
sentrivana b0ee152
.
sentrivana bb8b074
Merge branch 'master' into ivana/toxgen/httpx
sentrivana 661d9d7
?
sentrivana f0a23d9
Merge branch 'master' into ivana/toxgen/httpx
sentrivana 9b32671
Merge branch 'master' into ivana/toxgen/httpx
sentrivana ac91710
Merge branch 'master' into ivana/toxgen/httpx
sentrivana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,73 +22,6 @@ env: | |
| CACHED_BUILD_PATHS: | | ||
| ${{ github.workspace }}/dist-serverless | ||
| jobs: | ||
| test-network-latest: | ||
| name: Network (latest) | ||
| timeout-minutes: 30 | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.9","3.12","3.13"] | ||
| # python3.6 reached EOL and is no longer being supported on | ||
| # new versions of hosted runners on Github Actions | ||
| # ubuntu-20.04 is the last version that supported python3.6 | ||
| # see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877 | ||
| os: [ubuntu-22.04] | ||
| # Use Docker container only for Python 3.6 | ||
| container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }} | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - uses: actions/setup-python@v6 | ||
| if: ${{ matrix.python-version != '3.6' }} | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| allow-prereleases: true | ||
| - name: Setup Test Env | ||
| run: | | ||
| pip install "coverage[toml]" tox | ||
| - name: Erase coverage | ||
| run: | | ||
| coverage erase | ||
| - name: Test grpc latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-grpc-latest" | ||
| - name: Test httpx latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-httpx-latest" | ||
| - name: Test requests latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-requests-latest" | ||
| - name: Generate coverage XML (Python 3.6) | ||
| if: ${{ !cancelled() && matrix.python-version == '3.6' }} | ||
| run: | | ||
| export COVERAGE_RCFILE=.coveragerc36 | ||
| coverage combine .coverage-sentry-* | ||
| coverage xml --ignore-errors | ||
| - name: Generate coverage XML | ||
| if: ${{ !cancelled() && matrix.python-version != '3.6' }} | ||
| run: | | ||
| coverage combine .coverage-sentry-* | ||
| coverage xml | ||
| - name: Upload coverage to Codecov | ||
| if: ${{ !cancelled() }} | ||
| uses: codecov/[email protected] | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: coverage.xml | ||
| # make sure no plugins alter our coverage reports | ||
| plugins: noop | ||
| verbose: true | ||
| - name: Upload test results to Codecov | ||
| if: ${{ !cancelled() }} | ||
| uses: codecov/test-results-action@v1 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: .junitxml | ||
| verbose: true | ||
| test-network-pinned: | ||
| name: Network (pinned) | ||
| timeout-minutes: 30 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Parameter Causes Version Constraint Ignore
The
_supports_lowestfunction callssupported_python_versionswithout passing thereleaseparameter. This preventssupported_python_versionsfrom correctly processing dictionary-based Python version constraints (e.g., for httpx), which require thereleaseparameter. Consequently, these constraints are ignored, leading_supports_lowestto incorrectly returnFalse.