fix(fastapi): do not consume request body #4792
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can mount any ASGI app to a FastAPI or Starlette route. You can also parse the request body manually using the
receivecallable on FastAPI's and Starlette'sRequestobjects.In either case, reading
json(),form()orbody()in the patched route handler consumes the request body stream, leaving no stream for the application to read. If the user relies on these high-level Starlette methods then there is no issue because Starlette caches the result. Combining our FastAPI or Starlette integrations with low-level ASGI request body parsing is problematic.Approach in this PR:
json(),form()orbody(), cache the result on the ASGI scope and attach the result to events as before.Closes #4764