chore: Remove old metrics code #4899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-alderman-webb
approved these changes
Oct 9, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # and remove it (if it is present, i.e. not the very last char in an eof terminated envelope) | ||
| payload = f.readline().rstrip(b"\n") | ||
| if headers.get("type") in ("event", "transaction", "metric_buckets"): | ||
| if headers.get("type") in ("event", "transaction"): |
There was a problem hiding this comment.
Bug: Metric Buckets Payload Deserialization Failure
The deserialize_from method stopped parsing metric_buckets payloads as JSON. This means existing envelopes with metric_buckets will now be deserialized as raw bytes, which could cause runtime errors when a parsed object is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove old metrics code to make way for #4898
Metrics was always an experimental feature and Sentry stopped accepting metrics a year ago.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)