feat(stdlib): Add source information for slow outgoing HTTP requests #4902
+319
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| span.finish() | ||
|
|
||
| with capture_internal_exceptions(): | ||
| add_http_request_source(span) |
There was a problem hiding this comment.
Bug: Span Data Overwriting After Completion
The add_http_request_source call is placed after span.finish() in the finally block. Adding source information to an already finished span means this data might not be properly recorded, as finished spans are generally immutable.
There was a problem hiding this comment.
I placed add_http_request_source(span) after the span is finished because you need the end timestamp to determine the delay in receiving a response to the HTTP request.
It's done analogously in asyncpg and sqlalchemy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add code source as described in getsentry/sentry-docs#15161.
Factors out functionality from SQL query source and tests that it works in the HTTP request setting.
Issues
Closes #4881
Reminders
tox -e linters.feat:,fix:,ref:,meta:)