feat: Add source information for slow outgoing HTTP requests #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sentrivana
approved these changes
Oct 10, 2025
| span.finish() | ||
|
|
||
| with capture_internal_exceptions(): | ||
| add_http_request_source(span) |
There was a problem hiding this comment.
Fun fact: It'd be a concern in (P)OTel as finished OTel spans can't be modified, but Sentry spans can so all good.
…4904) Uses functionality from SQL query source and tests that it works in the HTTP request setting.
alexander-alderman-webb
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ry-python into webb/http-client-location
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add code source as described in getsentry/sentry-docs#15161.
Factors out functionality from SQL query source and tests that it works in the HTTP request setting.
Issues
Closes #4881
Reminders
tox -e linters.feat:,fix:,ref:,meta:)