Skip to content

Conversation

@shellmayr
Copy link
Member

@shellmayr shellmayr commented Oct 31, 2025

  • Add a map that contains integrations that should be deactivated when others are active to prevent duplicate spans, etc.
  • Allow positive and negative overrides by users
  • Add the existing langchain deactivations for anthropic and openai
  • Simplifies setup for users, because they don't have to add the lower level integrations to the disabled integrations array in the init

Closes TET-1304

@linear
Copy link

linear bot commented Oct 31, 2025



_INTEGRATION_DEACTIVATES = {
"langchain": ["openai", "anthropic"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not great, because we may introduce typos. Not sure if we can make this somewhat more integration without importing the integrations (which we don't want to do for obvious reasons)

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.98%. Comparing base (2d49b74) to head (1c9a231).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/__init__.py 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5052      +/-   ##
==========================================
+ Coverage   83.93%   83.98%   +0.04%     
==========================================
  Files         179      179              
  Lines       17893    17899       +6     
  Branches     3181     3187       +6     
==========================================
+ Hits        15019    15032      +13     
+ Misses       1909     1899      -10     
- Partials      965      968       +3     
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 86.95% <84.61%> (-0.55%) ⬇️

... and 6 files with indirect coverage changes

@shellmayr shellmayr marked this pull request as ready for review October 31, 2025 13:30
@shellmayr shellmayr requested a review from a team as a code owner October 31, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants