Skip to content

feat(integrations): add ability to auto-deactivate lower-level integrations based on map #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 4, 2025
Merged

feat(integrations): add ability to auto-deactivate lower-level integrations based on map #5052

merged 7 commits into from
Nov 4, 2025

Conversation

@shellmayr
Copy link
Member

@shellmayr shellmayr commented Oct 31, 2025 •
edited
Loading

  • Add a map that contains integrations that should be deactivated when others are active to prevent duplicate spans, etc.
  • Allow positive and negative overrides by users
  • Add the existing langchain deactivations for anthropic and openai
  • Simplifies setup for users, because they don't have to add the lower level integrations to the disabled integrations array in the init

Closes TET-1304

@linear
Copy link

linear bot commented Oct 31, 2025

TET-1304 Python: Disable conflicting integrations during import

shellmayr
shellmayr commented Oct 31, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.95%. Comparing base (7264a9f) to head (b34d342).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/__init__.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5052      +/-   ##
==========================================
+ Coverage   83.94%   83.95%   +0.01%     
==========================================
  Files         179      179              
  Lines       17904    17916      +12     
  Branches     3179     3187       +8     
==========================================
+ Hits        15030    15042      +12     
  Misses       1902     1902              
  Partials      972      972
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 88.04% <91.66%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

@shellmayr shellmayr marked this pull request as ready for review October 31, 2025 13:30
@shellmayr shellmayr requested a review from a team as a code owner October 31, 2025 13:30
alexander-alderman-webb
alexander-alderman-webb reviewed Nov 3, 2025
View reviewed changes
@alexander-alderman-webb
Copy link
Contributor

alexander-alderman-webb commented Nov 3, 2025

Looks good overall, let's get the tests running in CI and then we're good to go.

@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Nov 3, 2025
Merged
@alexander-alderman-webb
remove forking
4db7783
@alexander-alderman-webb
ci: Add tests for deactivating integrations to misc workflow (#5061)
3697471 
Adds a new tox environment to run the tests for auto-deactivating integrations that result in duplicate spans.

The tests in the new environment are run as part of the `Test Misc` workflow.
@alexander-alderman-webb
Copy link
Contributor

alexander-alderman-webb commented Nov 4, 2025

I'll resolve the conflicts as well.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@shellmayr shellmayr merged commit e910302 into master Nov 4, 2025
134 of 136 checks passed
@shellmayr shellmayr deleted the shellmayr/feat/auto-deactivate-lower-level-integartions branch November 4, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shellmayr @alexander-alderman-webb