Skip to content

tests(openai-agents): Remove MagicMock from ModelResponse #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −21
Open

tests(openai-agents): Remove MagicMock from ModelResponse #5053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4412d5e
tests(openai-agents): Remove MagicMock from ModelResponse
alexander-alderman-webb Oct 31, 2025
a5c0591
.
alexander-alderman-webb Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions tests/integrations/openai_agents/test_openai_agents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,6 @@ async def test_handoff_span(sentry_init, capture_events, mock_usage):
name="transfer_to_secondary_agent",
type="function_call",
arguments="{}",
function=MagicMock(
name="transfer_to_secondary_agent", arguments="{}"
),
)
],
usage=mock_usage,
Expand Down Expand Up @@ -377,9 +374,6 @@ def simple_test_tool(message: str) -> str:
name="simple_test_tool",
type="function_call",
arguments='{"message": "hello"}',
function=MagicMock(
name="simple_test_tool", arguments='{"message": "hello"}'
),
)

# First response with tool call
Expand Down Expand Up @@ -507,11 +501,8 @@ def simple_test_tool(message: str) -> str:
assert ai_client_span1["data"]["gen_ai.usage.output_tokens"] == 5
assert ai_client_span1["data"]["gen_ai.usage.output_tokens.reasoning"] == 0
assert ai_client_span1["data"]["gen_ai.usage.total_tokens"] == 15
assert re.sub(
r"SerializationIterator\(.*\)",
"NOT_CHECKED",
ai_client_span1["data"]["gen_ai.response.tool_calls"],
) == safe_serialize(

assert ai_client_span1["data"]["gen_ai.response.tool_calls"] == safe_serialize(
[
{
"arguments": '{"message": "hello"}',
Expand All @@ -520,7 +511,6 @@ def simple_test_tool(message: str) -> str:
"type": "function_call",
"id": "call_123",
"status": None,
"function": "NOT_CHECKED",
}
]
)
Expand Down Expand Up @@ -559,11 +549,7 @@ def simple_test_tool(message: str) -> str:
== available_tools
)
assert ai_client_span2["data"]["gen_ai.request.max_tokens"] == 100
assert re.sub(
r"SerializationIterator\(.*\)",
"NOT_CHECKED",
ai_client_span2["data"]["gen_ai.request.messages"],
) == safe_serialize(
assert ai_client_span2["data"]["gen_ai.request.messages"] == safe_serialize(
[
{
"role": "system",
Expand All @@ -586,7 +572,6 @@ def simple_test_tool(message: str) -> str:
"name": "simple_test_tool",
"type": "function_call",
"id": "call_123",
"function": "NOT_CHECKED",
}
],
},
Expand Down Expand Up @@ -1111,9 +1096,6 @@ def failing_tool(message: str) -> str:
name="failing_tool",
type="function_call",
arguments='{"message": "test"}',
function=MagicMock(
name="failing_tool", arguments='{"message": "test"}'
),
)

# First response with tool call
Expand Down