Skip to content

fix: Add hard limit to log batcher #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2025
+40 −1
Merged

fix: Add hard limit to log batcher #5069

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efed20d
fix: Add hard limit to log batcher
alexander-alderman-webb Nov 5, 2025
a814d96
record dropping logs and test
alexander-alderman-webb Nov 5, 2025
50910bc
check transport is not None
alexander-alderman-webb Nov 5, 2025
d6cfbf8
import
alexander-alderman-webb Nov 5, 2025
90520d3
add min python to test
alexander-alderman-webb Nov 5, 2025
83e206a
Merge branch 'master' into webb/log-batcher-upper-bound
alexander-alderman-webb Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sentry_sdk/_log_batcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

class LogBatcher:
MAX_LOGS_BEFORE_FLUSH = 100
MAX_LOGS_BEFORE_DROP = 1_000
FLUSH_WAIT_TIME = 5.0

def __init__(
Expand Down Expand Up @@ -79,6 +80,9 @@ def add(
return None

with self._lock:
if len(self._log_buffer) >= self.MAX_LOGS_BEFORE_DROP:
return None

self._log_buffer.append(log)
if len(self._log_buffer) >= self.MAX_LOGS_BEFORE_FLUSH:
self._flush_event.set()
Expand Down