-
Notifications
You must be signed in to change notification settings - Fork 571
Add back span status #5147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add back span status #5147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
3ad2155 to
02476b7
Compare
Member
Author
ffc345d to
811df06
Compare
For some reason since Performance was implemented ages ago, we were not sending the `span.status` field at all. Add it back since we are moving to a Span-First worls and Agent Monitoring also expects span statuses to be correct for some product features. Some other notes regarding the status mess: * the transaction status is added to the `trace_context` - this is fine * the span status is also added as a tag, this should be removed in a major since it's redundant * `set_http_status` further adds another tag called `http.status_code`, remove this in the major too
811df06 to
d7e8f2d
Compare
Member
Author
|
major cleanup tracked in #5154 |
alexander-alderman-webb
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
For some reason since Performance was implemented ages ago, we were not sending the
span.statusfield at all.Add it back since we are moving to a Span-First world and Agent Monitoring also expects span statuses to be correct for some product features.
Some other notes regarding the status mess:
trace_context- this is fineset_http_statusfurther adds another tag calledhttp.status_code, remove this in the major tooIssues
span.status#5059