Skip to content

test: fix flaky threading test #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sl0thentr0py wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test: fix flaky threading test #5700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"Bash(grep:*)",
"Bash(mv:*)",
"Bash(source .venv/bin/activate)",
"Bash(source tox.venv/bin/activate:*)",
"Bash(tox:*)",
"Bash(tox.venv/bin/tox:*)",
"Bash(.tox/*/bin/python:*)",
Expand Down
6 changes: 2 additions & 4 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,14 +942,12 @@ def target():
assert (main_thread.ident, main_thread.name) == results.get(timeout=1)


@pytest.mark.skipif(PY38, reason="Flakes a lot on 3.8 in CI.")
def test_get_current_thread_meta_failed_to_get_main_thread():
results = Queue(maxsize=1)

def target():
with mock.patch("threading.current_thread", side_effect=["fake thread"]):
with mock.patch("threading.current_thread", side_effect=["fake thread"]):
results.put(get_current_thread_meta())
with mock.patch("threading.current_thread", return_value="fake thread"):
results.put(get_current_thread_meta())

main_thread = threading.main_thread()

Expand Down
Loading