feat(db): Distinguish async vs sync database drivers using db.driver attribute#5711
Open
harryautomazione wants to merge 4 commits intogetsentry:masterfrom
Open
feat(db): Distinguish async vs sync database drivers using db.driver attribute#5711harryautomazione wants to merge 4 commits intogetsentry:masterfrom
harryautomazione wants to merge 4 commits intogetsentry:masterfrom
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
|
Currently blocked by convention approval: #5463 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds
db.driverattribute to database spans insqlalchemyandasyncpgintegrations to allow distinguishing between async and sync executions.Fixes #5463
Why
In performance dashboards or logs, all DB spans appear generically (
op: db). This makes it hard to identify when an application accidentally triggers blocking sync DB calls inside an async loop (eg. FastAPI).How
_set_db_data, usesconn.engine.dialect.driver(e.g.,aiosqlite,asyncpg,psycopg2).db.driverto"asyncpg".Verification Details
Verified locally using an async SQLAlchemy context where the attribute
db.driverwas successfully populated with"aiosqlite".Checklist