Skip to content

Commit f855e1e

Browse files
committed
meta: Changelog for 0.38.0
1 parent 44759b7 commit f855e1e

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## v0.38.0
4+
5+
- [Android] Remove requirement to pass in `MainApplication` `new RNSentryPackage(MainApplication.this)`
6+
37
## v0.37.1
48

59
- [Android] Call event callbacks even on failure to trigger crashes when device is offline

android/src/main/java/io/sentry/RNSentryModule.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
public class RNSentryModule extends ReactContextBaseJavaModule {
5252

5353
private static final Pattern mJsModuleIdPattern = Pattern.compile("(?:^|[/\\\\])(\\d+\\.js)$");
54-
private static final String versionString = "0.35.4";
54+
private static final String versionString = "0.37.1";
5555
private static final String sdkName = "sentry-react-native";
5656

5757
private final ReactApplicationContext reactContext;
@@ -102,8 +102,9 @@ public void startWithDsnString(String dsnString, final ReadableMap options, Prom
102102
sentryClient.addEventSendCallback(new EventSendCallback() {
103103
@Override
104104
public void onFailure(Event event, Exception exception) {
105-
// This needs to be there, otherwise in case of not internet the users app will not
106-
// crash since we do not propagate the error further.
105+
// This needs to be there, otherwise in case of no internet the users app will not
106+
// crash since we do not propagate the error further. The system needs to be
107+
// overhauled to remove this "hack".
107108
RNSentryEventEmitter.sendEvent(reactContext, RNSentryEventEmitter.SENTRY_EVENT_STORED, new WritableNativeMap());
108109
RNSentryEventEmitter.sendEvent(reactContext, RNSentryEventEmitter.SENTRY_EVENT_SENT_SUCCESSFULLY, new WritableNativeMap());
109110
}

docs/manual-setup.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ Please make sure your ``MainApplication.java`` looks something like this:
134134
protected List<ReactPackage> getPackages() {
135135
return Arrays.<ReactPackage>asList(
136136
new MainReactPackage(),
137-
new RNSentryPackage(MainApplication.this)
137+
new RNSentryPackage()
138138
);
139139
}
140140

0 commit comments

Comments
 (0)