-
-
Notifications
You must be signed in to change notification settings - Fork 353
feat: Bump to Sentry Javascript V9 #4568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
04b6c06
bump SDKs
lucas-zimerman 0dc4bca
bump SDKs
lucas-zimerman 382fef6
fix build
lucas-zimerman 33af36c
fix tests
lucas-zimerman ad6a76c
fix tests
lucas-zimerman 15342a2
fix lint errors
lucas-zimerman c267f9b
test ts 5.0
lucas-zimerman efea84f
rollback
lucas-zimerman 65a10d5
Merge branch 'v7' into lz/bump/jsv9
lucas-zimerman 028dbf9
fix merge conflict with yarn
lucas-zimerman a57459a
fix new lint issue
lucas-zimerman 5de9867
sync yarn.lock with V7 branch and install new packages
lucas-zimerman ae65521
ensure we are using the JS version from the default node resolution
lucas-zimerman bd64169
update changelog with javascript version bump
lucas-zimerman 39a81c7
fix check type (#4587)
lucas-zimerman 3a4fd4c
add major changes to the SDK
lucas-zimerman d8088ad
fix lint
lucas-zimerman 6f71cda
review check: fix changelog PR number / Fix wrapper incorrect null c…
lucas-zimerman 55c1961
fix incorrect cli version
lucas-zimerman 97853c6
fix lint
lucas-zimerman dc2e123
Merge branch 'v7' into lz/bump/jsv9
lucas-zimerman 9a0b21e
remove shutdowntimeout from android / use newer wizard version
lucas-zimerman 45ee6fa
rollback feedback test change, rollback jest version, fix safe test
lucas-zimerman 816b506
return shutdowntimeout
lucas-zimerman 25bf147
explain tracing sample rate
lucas-zimerman 8584214
fix tracing extension test
lucas-zimerman a26497e
Merge branch 'v7' into lz/bump/jsv9
lucas-zimerman 499e5a3
lint fix
lucas-zimerman 578ad2c
update changelog
lucas-zimerman d7fe6c6
merge v7
lucas-zimerman b08c54f
fix yarn lock merge/ fix ts-jest version no longer exists / fix cor…
lucas-zimerman 19197f3
fix lint on addTimeToInitialDisplay
lucas-zimerman 709697c
fix issue with UIManager test
lucas-zimerman a5ddcda
moved major changes to the correct spot
lucas-zimerman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Browser SDK now recommends directly using https://github.com/getsentry/sentry-javascript/blob/defeaaf99ff6180be714ae770ce1ed0da6243676/packages/browser/src/integrations/browsersession.ts#L12
RN SDK has also
enableAutoSessionTracking
sentry-react-native/packages/core/src/js/options.ts
Line 45 in f8289de
autoSessionTracking
andenableAutoSessionTracking
were two unrelated flags.We should make it clear to the users.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In regard to this, should we remove the integration
autoSessionTracking
when running natively?Before it was only added when autoSessionTracking was added, but now its added by default.
We could exclude it when enableAutioSessionTracking is set to true and it's running on browser, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense, let's add the
browserSessionIntegration
whenenableAutioSessionTracking
and we are running in a browser.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also do this in a follow up PR.