Skip to content

Conversation

lucas-zimerman
Copy link
Collaborator

Based on getsentry/sentry-javascript#17364

original context;

This PR fixes a long-standing problem in the SDK where it would set incorrect information about when Relay should (not) infer IP addresses from sent envelope requests.

Previously, this was thought to be controlled by setting event.user.ip_address: '{{auto}}'. However, after an incident in Relay, it was determined that this is in fact not a reliably way to control IP inference. Instead, SDKs should set event.sdk.settings.infer_ip: 'auto' | 'never' (see closes https://github.com/getsentry/sentry-javascript/issues/16252).
Unfortunately, this wasn't implemented immediately but is taken care of in this PR.

(FWIW, the only reason why Relay continued to infer IP addresses for the JS SDK was because it is excempt from logic that would infer IP addresses only if user.ip_address was set to '{{auto}}'. This is necessary to backwards compatibility with older SDKs.)

Follow-ups: We likely also need to adjust the logic in Electron and Lynx (at the very least remove setting user.ip_address).

closes https://github.com/getsentry/sentry-javascript/issues/17351
closes https://github.com/getsentry/sentry-javascript/issues/16252

Instead of bumping o V10, the fix was patched on the current release.

Copy link
Contributor

github-actions bot commented Aug 20, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.10 ms 446.96 ms 8.86 ms
Size 17.75 MiB 20.15 MiB 2.41 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
64cd15c 439.02 ms 427.63 ms -11.39 ms
7be1f99 454.83 ms 461.36 ms 6.53 ms
e2fa43d 451.68 ms 462.42 ms 10.74 ms
3e0a5f9 401.72 ms 394.98 ms -6.74 ms
d916aa3 425.37 ms 427.02 ms 1.65 ms
785ffb1 471.92 ms 460.96 ms -10.96 ms
534ba8c 484.00 ms 499.93 ms 15.93 ms
eb07ba3 470.04 ms 473.35 ms 3.31 ms

App size

Revision Plain With Sentry Diff
64cd15c 17.75 MiB 20.15 MiB 2.41 MiB
7be1f99 17.75 MiB 20.15 MiB 2.41 MiB
e2fa43d 17.75 MiB 20.15 MiB 2.41 MiB
3e0a5f9 17.75 MiB 20.15 MiB 2.41 MiB
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
785ffb1 17.75 MiB 20.15 MiB 2.41 MiB
534ba8c 17.75 MiB 20.15 MiB 2.41 MiB
eb07ba3 17.75 MiB 20.15 MiB 2.41 MiB

Copy link
Contributor

github-actions bot commented Aug 20, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.98 ms 521.62 ms 117.65 ms
Size 7.15 MiB 8.42 MiB 1.27 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3e0a5f9+dirty 379.92 ms 450.96 ms 71.04 ms
d916aa3+dirty 411.72 ms 451.76 ms 40.03 ms
785ffb1+dirty 380.65 ms 451.83 ms 71.18 ms
534ba8c+dirty 472.35 ms 537.31 ms 64.96 ms
7be1f99+dirty 369.02 ms 399.60 ms 30.58 ms
64cd15c+dirty 488.79 ms 483.54 ms -5.24 ms
eb07ba3+dirty 419.49 ms 482.12 ms 62.63 ms
e2fa43d+dirty 326.56 ms 372.88 ms 46.32 ms

App size

Revision Plain With Sentry Diff
3e0a5f9+dirty 7.15 MiB 8.42 MiB 1.27 MiB
d916aa3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
785ffb1+dirty 7.15 MiB 8.42 MiB 1.27 MiB
534ba8c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
7be1f99+dirty 7.15 MiB 8.42 MiB 1.27 MiB
64cd15c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
eb07ba3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e2fa43d+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Copy link
Contributor

github-actions bot commented Aug 20, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.90 ms 1234.50 ms 3.60 ms
Size 2.63 MiB 3.81 MiB 1.18 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb07ba3+dirty 1222.46 ms 1220.37 ms -2.08 ms
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
3e0a5f9+dirty 1226.94 ms 1230.02 ms 3.08 ms
e2fa43d+dirty 1216.04 ms 1232.65 ms 16.61 ms
785ffb1+dirty 1237.63 ms 1240.50 ms 2.87 ms
7be1f99+dirty 1226.69 ms 1217.76 ms -8.93 ms
98f632c+dirty 1236.40 ms 1241.62 ms 5.22 ms
534ba8c+dirty 1230.22 ms 1231.18 ms 0.96 ms
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms

App size

Revision Plain With Sentry Diff
eb07ba3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
3e0a5f9+dirty 2.63 MiB 3.81 MiB 1.18 MiB
e2fa43d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
785ffb1+dirty 2.63 MiB 3.81 MiB 1.18 MiB
7be1f99+dirty 2.63 MiB 3.81 MiB 1.18 MiB
98f632c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
534ba8c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB

Copy link
Contributor

github-actions bot commented Aug 20, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.06 ms 1214.27 ms 4.21 ms
Size 3.19 MiB 4.38 MiB 1.19 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
534ba8c+dirty 1225.00 ms 1237.43 ms 12.43 ms
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms
785ffb1+dirty 1213.71 ms 1213.37 ms -0.35 ms
3e0a5f9+dirty 1233.65 ms 1239.10 ms 5.45 ms
eb07ba3+dirty 1214.49 ms 1221.59 ms 7.10 ms
7be1f99+dirty 1222.43 ms 1217.15 ms -5.28 ms
e2fa43d+dirty 1224.43 ms 1235.40 ms 10.98 ms

App size

Revision Plain With Sentry Diff
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
534ba8c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
785ffb1+dirty 3.19 MiB 4.38 MiB 1.19 MiB
3e0a5f9+dirty 3.19 MiB 4.38 MiB 1.19 MiB
eb07ba3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
7be1f99+dirty 3.19 MiB 4.38 MiB 1.19 MiB
e2fa43d+dirty 3.19 MiB 4.38 MiB 1.19 MiB

@lucas-zimerman lucas-zimerman marked this pull request as ready for review August 20, 2025 16:01
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸
Thank you for implementing this for V6 @lucas-zimerman 🙇

@antonis antonis merged commit 21c9e75 into main Aug 25, 2025
87 of 88 checks passed
@antonis antonis deleted the lz/patch-pii-v6 branch August 25, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants