Skip to content

chore(deps): v7: update JavaScript SDK to v10 #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 28, 2025
Merged

chore(deps): v7: update JavaScript SDK to v10 #5111

merged 16 commits into from
Aug 28, 2025

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Aug 28, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps JS SDK to 10.7.0. Some refactoring was needed due to:

💡 Motivation and Context

JS 10 https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md#1000

https://docs.sentry.io/platforms/javascript/migration/v9-to-v10/

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.94 ms 396.04 ms -13.90 ms
Size 17.75 MiB 19.68 MiB 1.93 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
10ec2e1 435.28 ms 431.58 ms -3.70 ms
472960b 418.84 ms 405.38 ms -13.46 ms
11cc947 501.96 ms 486.04 ms -15.92 ms
0e27665 356.27 ms 367.74 ms 11.47 ms
7eff2d7 420.64 ms 401.86 ms -18.78 ms
fb47c4a 435.33 ms 434.94 ms -0.40 ms
f870f2d 444.67 ms 449.62 ms 4.95 ms
26515b5 446.24 ms 441.91 ms -4.33 ms
20d0171 366.62 ms 366.43 ms -0.19 ms
c26618b 435.76 ms 430.14 ms -5.62 ms

App size

Revision Plain With Sentry Diff
10ec2e1 17.75 MiB 19.60 MiB 1.85 MiB
472960b 17.75 MiB 19.58 MiB 1.83 MiB
11cc947 17.75 MiB 19.60 MiB 1.86 MiB
0e27665 17.75 MiB 19.60 MiB 1.85 MiB
7eff2d7 17.75 MiB 19.60 MiB 1.85 MiB
fb47c4a 17.75 MiB 19.60 MiB 1.85 MiB
f870f2d 17.75 MiB 19.58 MiB 1.83 MiB
26515b5 17.75 MiB 19.60 MiB 1.86 MiB
20d0171 17.75 MiB 19.60 MiB 1.85 MiB
c26618b 17.75 MiB 19.60 MiB 1.85 MiB

Previous results on branch: antonis/bump-js10

Startup times

Revision Plain With Sentry Diff
aeced70 413.43 ms 405.10 ms -8.33 ms

App size

Revision Plain With Sentry Diff
aeced70 17.75 MiB 19.68 MiB 1.93 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.65 ms 1227.16 ms 9.51 ms
Size 2.63 MiB 3.87 MiB 1.24 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
c26618b+dirty 1230.06 ms 1233.30 ms 3.24 ms
0e27665+dirty 1213.52 ms 1237.61 ms 24.09 ms
20d0171+dirty 1214.96 ms 1215.20 ms 0.25 ms
472960b+dirty 1213.96 ms 1222.58 ms 8.62 ms
26515b5+dirty 1240.49 ms 1237.19 ms -3.30 ms
fb47c4a+dirty 1231.00 ms 1231.33 ms 0.33 ms
7eff2d7+dirty 1225.34 ms 1234.53 ms 9.19 ms
11cc947+dirty 1239.65 ms 1239.64 ms -0.01 ms
10ec2e1+dirty 1228.02 ms 1237.54 ms 9.52 ms
3c99746+dirty 1215.12 ms 1222.31 ms 7.18 ms

App size

Revision Plain With Sentry Diff
c26618b+dirty 2.63 MiB 3.82 MiB 1.19 MiB
0e27665+dirty 2.63 MiB 3.80 MiB 1.17 MiB
20d0171+dirty 2.63 MiB 3.80 MiB 1.17 MiB
472960b+dirty 2.63 MiB 3.79 MiB 1.15 MiB
26515b5+dirty 2.63 MiB 3.83 MiB 1.19 MiB
fb47c4a+dirty 2.63 MiB 3.80 MiB 1.17 MiB
7eff2d7+dirty 2.63 MiB 3.79 MiB 1.16 MiB
11cc947+dirty 2.63 MiB 3.82 MiB 1.19 MiB
10ec2e1+dirty 2.63 MiB 3.82 MiB 1.19 MiB
3c99746+dirty 2.63 MiB 3.78 MiB 1.15 MiB

Previous results on branch: antonis/bump-js10

Startup times

Revision Plain With Sentry Diff
aeced70+dirty 1222.69 ms 1222.17 ms -0.53 ms

App size

Revision Plain With Sentry Diff
aeced70+dirty 2.63 MiB 3.87 MiB 1.24 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 370.68 ms 421.73 ms 51.05 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
0e27665+dirty 355.91 ms 422.52 ms 66.61 ms
7eff2d7+dirty 393.13 ms 426.77 ms 33.65 ms
f870f2d+dirty 398.49 ms 434.24 ms 35.75 ms
26515b5+dirty 389.83 ms 443.94 ms 54.11 ms
472960b+dirty 394.39 ms 376.18 ms -18.20 ms
11cc947+dirty 385.96 ms 420.08 ms 34.12 ms
20d0171+dirty 380.17 ms 422.57 ms 42.40 ms
c26618b+dirty 354.44 ms 414.73 ms 60.29 ms
10ec2e1+dirty 373.87 ms 443.64 ms 69.78 ms
3c99746+dirty 400.65 ms 399.59 ms -1.06 ms

App size

Revision Plain With Sentry Diff
0e27665+dirty 7.15 MiB 8.35 MiB 1.20 MiB
7eff2d7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
f870f2d+dirty 7.15 MiB 8.34 MiB 1.18 MiB
26515b5+dirty 7.15 MiB 8.36 MiB 1.21 MiB
472960b+dirty 7.15 MiB 8.34 MiB 1.18 MiB
11cc947+dirty 7.15 MiB 8.36 MiB 1.20 MiB
20d0171+dirty 7.15 MiB 8.35 MiB 1.20 MiB
c26618b+dirty 7.15 MiB 8.36 MiB 1.20 MiB
10ec2e1+dirty 7.15 MiB 8.35 MiB 1.20 MiB
3c99746+dirty 7.15 MiB 8.34 MiB 1.18 MiB

Previous results on branch: antonis/bump-js10

Startup times

Revision Plain With Sentry Diff
aeced70+dirty 358.91 ms 409.28 ms 50.37 ms

App size

Revision Plain With Sentry Diff
aeced70+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.63 ms 1214.06 ms 1.43 ms
Size 3.19 MiB 4.44 MiB 1.25 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
c26618b+dirty 1228.54 ms 1236.52 ms 7.98 ms
0e27665+dirty 1207.12 ms 1220.33 ms 13.20 ms
20d0171+dirty 1214.21 ms 1220.31 ms 6.10 ms
472960b+dirty 1243.67 ms 1233.57 ms -10.11 ms
26515b5+dirty 1216.98 ms 1224.24 ms 7.27 ms
fb47c4a+dirty 1243.40 ms 1245.86 ms 2.46 ms
7eff2d7+dirty 1224.84 ms 1227.94 ms 3.10 ms
11cc947+dirty 1218.92 ms 1234.24 ms 15.33 ms
10ec2e1+dirty 1229.04 ms 1222.28 ms -6.76 ms
3c99746+dirty 1227.65 ms 1228.81 ms 1.16 ms

App size

Revision Plain With Sentry Diff
c26618b+dirty 3.19 MiB 4.39 MiB 1.20 MiB
0e27665+dirty 3.19 MiB 4.37 MiB 1.18 MiB
20d0171+dirty 3.19 MiB 4.37 MiB 1.18 MiB
472960b+dirty 3.19 MiB 4.36 MiB 1.17 MiB
26515b5+dirty 3.19 MiB 4.39 MiB 1.20 MiB
fb47c4a+dirty 3.19 MiB 4.37 MiB 1.18 MiB
7eff2d7+dirty 3.19 MiB 4.36 MiB 1.17 MiB
11cc947+dirty 3.19 MiB 4.39 MiB 1.20 MiB
10ec2e1+dirty 3.19 MiB 4.39 MiB 1.20 MiB
3c99746+dirty 3.19 MiB 4.35 MiB 1.16 MiB

Previous results on branch: antonis/bump-js10

Startup times

Revision Plain With Sentry Diff
aeced70+dirty 1239.41 ms 1238.65 ms -0.76 ms

App size

Revision Plain With Sentry Diff
aeced70+dirty 3.19 MiB 4.44 MiB 1.25 MiB

@antonis antonis mentioned this pull request Aug 28, 2025
Closed
Base automatically changed from antonis/bump_to_android_sdk_8.20.0 to v7 August 28, 2025 10:14
antonis
antonis commented Aug 28, 2025
View reviewed changes
dev-packages/type-check/ts3.8-test/tsconfig.build.json
],
"compilerOptions": {
"skipLibCheck": false,
"skipLibCheck": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to handle the following type check errors

+ yarn type-check
node_modules/@sentry/browser/build/npm/types-ts3.8/integrations/webWorker.d.ts:4:25 - error TS2304: Cannot find name 'Worker'.

4     addWorker: (worker: Worker) => void;
                          ~~~~~~

node_modules/@sentry/core/build/types-ts3.8/utils/debug-logger.d.ts:18:47 - error TS2339: Property 'assert' does not exist on type 'Console'.

18     assert(...args: Parameters<typeof console.assert>): void;
                                                 ~~~~~~

node_modules/@sentry/core/build/types-ts3.8/utils/openai/types.d.ts:276:42 - error TS2304: Cannot find name 'AsyncIterable'.

276 export interface OpenAIStream<T> extends AsyncIterable<T> {
                                             ~~~~~~~~~~~~~

node_modules/@sentry/core/build/types-ts3.8/utils/openai/types.d.ts:277:13 - error TS2339: Property 'asyncIterator' does not exist on type 'SymbolConstructor'.

277     [Symbol.asyncIterator](): AsyncIterator<T>;
                ~~~~~~~~~~~~~

node_modules/@sentry/core/build/types-ts3.8/utils/openai/types.d.ts:277:31 - error TS2583: Cannot find name 'AsyncIterator'. Do you need to change your target library? Try changing the `lib` compiler option to es2015 or later.

277     [Symbol.asyncIterator](): AsyncIterator<T>;
                                  ~~~~~~~~~~~~~


Found 5 errors.

Any ideas on how to avoid this are more than welcome 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that changing "lib": ["es2020"] (from es2015) fixes 3 of the errors.

node_modules/@sentry/browser/build/npm/types-ts3.8/integrations/webWorker.d.ts:4:25 - error TS2304: Cannot find name 'Worker'.

4     addWorker: (worker: Worker) => void;
                          ~~~~~~

node_modules/@sentry/core/build/types-ts3.8/utils/debug-logger.d.ts:18:47 - error TS2339: Property 'assert' does not exist on type 'Console'.

18     assert(...args: Parameters<typeof console.assert>): void;
                                                 ~~~~~~


Found 2 errors.

@antonis antonis requested a review from alwx August 28, 2025 11:00
@antonis antonis mentioned this pull request Aug 28, 2025
Closed
@antonis
Copy link
Contributor Author

antonis commented Aug 28, 2025

Currently blocked due to the test failures all of which seem to start with the 9.38.0 (changes) bump.

lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
lucas-zimerman
lucas-zimerman reviewed Aug 28, 2025
View reviewed changes
@antonis
Copy link
Contributor Author

antonis commented Aug 28, 2025

Currently blocked due to the test failures all of which seem to start with the 9.38.0 (changes) bump.

It seems that the optimisation in getsentry/sentry-javascript#16890 was breaking jest fake timers. Fixed with c9098d7

@antonis antonis marked this pull request as ready for review August 28, 2025 18:54
@antonis antonis requested a review from lucas-zimerman August 28, 2025 18:54
lucas-zimerman
lucas-zimerman approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! LGTM!

@antonis antonis merged commit 3b2e69a into v7 Aug 28, 2025
118 of 122 checks passed
@antonis antonis deleted the antonis/bump-js10 branch August 28, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@alwx alwx Awaiting requested review from alwx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis @lucas-zimerman