Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Sep 8, 2025

Fixes SentryScreenFrames converted to swift in getsentry/sentry-cocoa#6094

#skip-changelog

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.20 ms 420.17 ms 23.97 ms
Size 17.75 MiB 19.70 MiB 1.95 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f70acbf+dirty 373.39 ms 382.81 ms 9.43 ms
49ef936+dirty 405.96 ms 417.22 ms 11.26 ms
7be1f99 454.83 ms 461.36 ms 6.53 ms
000da7a 454.46 ms 445.00 ms -9.46 ms
bfe454a+dirty 573.44 ms 579.46 ms 6.02 ms
7480abe+dirty 411.60 ms 405.81 ms -5.78 ms
64cd15c 439.02 ms 427.63 ms -11.39 ms
23080e5 384.85 ms 382.57 ms -2.28 ms
5526494 440.84 ms 448.36 ms 7.52 ms
c08359e 421.87 ms 445.37 ms 23.50 ms

App size

Revision Plain With Sentry Diff
f70acbf+dirty 17.75 MiB 19.68 MiB 1.94 MiB
49ef936+dirty 17.75 MiB 19.69 MiB 1.94 MiB
7be1f99 17.75 MiB 20.15 MiB 2.41 MiB
000da7a 17.75 MiB 19.68 MiB 1.94 MiB
bfe454a+dirty 17.75 MiB 19.69 MiB 1.94 MiB
7480abe+dirty 17.75 MiB 19.68 MiB 1.94 MiB
64cd15c 17.75 MiB 20.15 MiB 2.41 MiB
23080e5 17.75 MiB 19.68 MiB 1.94 MiB
5526494 17.75 MiB 19.68 MiB 1.93 MiB
c08359e 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision Plain With Sentry Diff
ede2a89 414.58 ms 395.16 ms -19.42 ms

App size

Revision Plain With Sentry Diff
ede2a89 17.75 MiB 19.68 MiB 1.94 MiB

Copy link
Contributor

github-actions bot commented Sep 8, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.44 ms 1238.73 ms 12.30 ms
Size 2.63 MiB 3.98 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ec14be7+dirty 1234.64 ms 1245.54 ms 10.90 ms
d751a5d+dirty 1215.57 ms 1220.56 ms 4.99 ms
23080e5+dirty 1216.02 ms 1224.94 ms 8.91 ms
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms
77061ed+dirty 1233.16 ms 1234.88 ms 1.71 ms
ba75c7c+dirty 1235.86 ms 1226.45 ms -9.41 ms
95aaf8a+dirty 1234.78 ms 1241.94 ms 7.16 ms
98f632c+dirty 1236.40 ms 1241.62 ms 5.22 ms
534ba8c+dirty 1230.22 ms 1231.18 ms 0.96 ms
a31630c+dirty 1229.09 ms 1230.94 ms 1.85 ms

App size

Revision Plain With Sentry Diff
ec14be7+dirty 2.63 MiB 3.98 MiB 1.34 MiB
d751a5d+dirty 2.63 MiB 3.98 MiB 1.34 MiB
23080e5+dirty 2.63 MiB 3.91 MiB 1.28 MiB
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
77061ed+dirty 2.63 MiB 3.98 MiB 1.34 MiB
ba75c7c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
95aaf8a+dirty 2.63 MiB 3.87 MiB 1.24 MiB
98f632c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
534ba8c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
a31630c+dirty 2.63 MiB 3.98 MiB 1.34 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision Plain With Sentry Diff
ede2a89+dirty 1218.37 ms 1224.38 ms 6.01 ms

App size

Revision Plain With Sentry Diff
ede2a89+dirty 2.63 MiB 3.91 MiB 1.28 MiB

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 328.47 ms 376.27 ms 47.80 ms
Size 7.15 MiB 8.42 MiB 1.27 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0b15d6+dirty 414.33 ms 448.85 ms 34.52 ms
f70acbf+dirty 520.12 ms 558.91 ms 38.79 ms
49ef936+dirty 333.72 ms 387.51 ms 53.79 ms
bfe454a+dirty 372.42 ms 424.52 ms 52.10 ms
7480abe+dirty 363.80 ms 431.34 ms 67.54 ms
20d5eaa+dirty 358.31 ms 442.37 ms 84.06 ms
c4e097a+dirty 382.43 ms 443.77 ms 61.34 ms
7be1f99+dirty 369.02 ms 399.60 ms 30.58 ms
64cd15c+dirty 488.79 ms 483.54 ms -5.24 ms
534ba8c+dirty 472.35 ms 537.31 ms 64.96 ms

App size

Revision Plain With Sentry Diff
a0b15d6+dirty 7.15 MiB 8.42 MiB 1.27 MiB
f70acbf+dirty 7.15 MiB 8.41 MiB 1.26 MiB
49ef936+dirty 7.15 MiB 8.42 MiB 1.26 MiB
bfe454a+dirty 7.15 MiB 8.42 MiB 1.26 MiB
7480abe+dirty 7.15 MiB 8.41 MiB 1.26 MiB
20d5eaa+dirty 7.15 MiB 8.42 MiB 1.27 MiB
c4e097a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
7be1f99+dirty 7.15 MiB 8.42 MiB 1.27 MiB
64cd15c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
534ba8c+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision Plain With Sentry Diff
ede2a89+dirty 398.04 ms 486.04 ms 88.00 ms

App size

Revision Plain With Sentry Diff
ede2a89+dirty 7.15 MiB 8.41 MiB 1.26 MiB

Copy link
Contributor

github-actions bot commented Sep 8, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.11 ms 1222.54 ms 0.43 ms
Size 3.19 MiB 4.55 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ec14be7+dirty 1229.62 ms 1230.53 ms 0.91 ms
d751a5d+dirty 1212.22 ms 1217.94 ms 5.71 ms
23080e5+dirty 1221.39 ms 1222.08 ms 0.70 ms
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms
77061ed+dirty 1210.77 ms 1218.45 ms 7.68 ms
ba75c7c+dirty 1236.14 ms 1240.69 ms 4.55 ms
95aaf8a+dirty 1206.83 ms 1213.65 ms 6.81 ms
98f632c+dirty 1221.38 ms 1229.26 ms 7.88 ms
534ba8c+dirty 1225.00 ms 1237.43 ms 12.43 ms
a31630c+dirty 1241.32 ms 1226.98 ms -14.34 ms

App size

Revision Plain With Sentry Diff
ec14be7+dirty 3.19 MiB 4.54 MiB 1.36 MiB
d751a5d+dirty 3.19 MiB 4.54 MiB 1.36 MiB
23080e5+dirty 3.19 MiB 4.48 MiB 1.29 MiB
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
77061ed+dirty 3.19 MiB 4.54 MiB 1.36 MiB
ba75c7c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
95aaf8a+dirty 3.19 MiB 4.44 MiB 1.25 MiB
98f632c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
534ba8c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
a31630c+dirty 3.19 MiB 4.54 MiB 1.36 MiB

Previous results on branch: itay/fix_sentreyscreenframes

Startup times

Revision Plain With Sentry Diff
ede2a89+dirty 1229.10 ms 1227.88 ms -1.23 ms

App size

Revision Plain With Sentry Diff
ede2a89+dirty 3.19 MiB 4.48 MiB 1.29 MiB

@antonis
Copy link
Contributor

antonis commented Sep 9, 2025

Thank you for opening this ahead of the changes Itay. The changes LGTM.
I'll keep this blocked till the changes land with the next version of Cocoa.

@antonis antonis added the Blocked label Sep 9, 2025
@itaybre
Copy link
Contributor Author

itaybre commented Oct 3, 2025

Already merged on sentry-cocoa, ready to merge the fix.

@antonis
Copy link
Contributor

antonis commented Oct 6, 2025

Thank you for the heads up Itay 🙇

Already merged on sentry-cocoa, ready to merge the fix.

Noting this to merge along the next Cocoa pump 📓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants