-
-
Notifications
You must be signed in to change notification settings - Fork 366
Convert SentryScreenFrames
to Swift
#6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itaybre
merged 19 commits into
main
from
itay/cocoa-547-convert-sentryscreenframes-to-swift
Oct 3, 2025
Merged
Convert SentryScreenFrames
to Swift
#6094
itaybre
merged 19 commits into
main
from
itay/cocoa-547-convert-sentryscreenframes-to-swift
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f2f69c | 1237.61 ms | 1266.96 ms | 29.35 ms |
e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
00d9740 | 1223.53 ms | 1249.75 ms | 26.22 ms |
5cbd333 | 1219.93 ms | 1241.76 ms | 21.83 ms |
d1c4916 | 1236.25 ms | 1266.76 ms | 30.51 ms |
37183fe | 1212.33 ms | 1238.92 ms | 26.59 ms |
1b008ee | 1209.57 ms | 1258.67 ms | 49.10 ms |
2609f7a | 1218.17 ms | 1241.34 ms | 23.17 ms |
e4ba9a7 | 1219.82 ms | 1230.89 ms | 11.07 ms |
5196f0d | 1213.35 ms | 1231.37 ms | 18.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f2f69c | 23.75 KiB | 913.38 KiB | 889.63 KiB |
e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
00d9740 | 23.75 KiB | 938.32 KiB | 914.57 KiB |
5cbd333 | 23.74 KiB | 969.77 KiB | 946.02 KiB |
d1c4916 | 23.75 KiB | 981.15 KiB | 957.40 KiB |
37183fe | 23.75 KiB | 913.63 KiB | 889.87 KiB |
1b008ee | 23.75 KiB | 929.71 KiB | 905.96 KiB |
2609f7a | 23.75 KiB | 867.04 KiB | 843.29 KiB |
e4ba9a7 | 23.75 KiB | 969.22 KiB | 945.47 KiB |
5196f0d | 23.75 KiB | 876.93 KiB | 853.19 KiB |
Previous results on branch: itay/cocoa-547-convert-sentryscreenframes-to-swift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ce9aaeb | 1218.53 ms | 1247.19 ms | 28.66 ms |
387a2ac | 1202.26 ms | 1235.83 ms | 33.58 ms |
39c2e42 | 1225.44 ms | 1251.08 ms | 25.64 ms |
cd01c20 | 1225.64 ms | 1245.30 ms | 19.66 ms |
2e6b4be | 1216.04 ms | 1256.43 ms | 40.39 ms |
496f9a5 | 1235.78 ms | 1257.64 ms | 21.86 ms |
5f7ee5f | 1235.24 ms | 1254.13 ms | 18.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ce9aaeb | 23.75 KiB | 974.48 KiB | 950.73 KiB |
387a2ac | 23.75 KiB | 964.28 KiB | 940.53 KiB |
39c2e42 | 23.74 KiB | 978.66 KiB | 954.92 KiB |
cd01c20 | 23.74 KiB | 972.09 KiB | 948.35 KiB |
2e6b4be | 23.75 KiB | 963.56 KiB | 939.82 KiB |
496f9a5 | 23.75 KiB | 983.34 KiB | 959.59 KiB |
5f7ee5f | 23.75 KiB | 966.10 KiB | 942.35 KiB |
Waiting for RN integration fix here: getsentry/sentry-react-native#5153 |
…coa-547-convert-sentryscreenframes-to-swift
philprime
reviewed
Sep 15, 2025
Sources/Swift/Core/Integrations/FramesTracking/SentryScreenFrames.swift
Outdated
Show resolved
Hide resolved
philprime
reviewed
Sep 26, 2025
Sources/Swift/Core/Integrations/FramesTracking/SentryScreenFrames.swift
Outdated
Show resolved
Hide resolved
…coa-547-convert-sentryscreenframes-to-swift
…coa-547-convert-sentryscreenframes-to-swift
…coa-547-convert-sentryscreenframes-to-swift
philprime
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Closes #6119