-
-
Notifications
You must be signed in to change notification settings - Fork 366
Convert SentryScreenFrames
to Swift
#6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itaybre
merged 19 commits into
main
from
itay/cocoa-547-convert-sentryscreenframes-to-swift
Oct 3, 2025
Merged
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4a3d084
Convert `SentryScreenFrames` to Swift
itaybre 36e74b3
Fix build on watchOS
itaybre 6ef608d
Import SentryDefines
itaybre e6bc73f
Fix build error on `iOS-Swift`
itaybre 34c4937
Add @_spi(Private) to `SentryFrameInfoTimeSeries`
itaybre 728ef95
Fix build on Xcode 14
itaybre 913f617
Fix Typo
itaybre dcd9dd5
Use fixed branch
itaybre 30a4890
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/co…
itaybre a2e5694
Fix `SentryScreenFrames` copy method
itaybre 42b6a5a
Merge branch 'main' into itay/cocoa-547-convert-sentryscreenframes-to…
itaybre 8504231
PR comment foxes
itaybre a059e8d
Bump size to 955KB
itaybre 6763b35
Merge branch 'main' into itay/cocoa-547-convert-sentryscreenframes-to…
itaybre 9ef599d
Merge branch 'main' into itay/cocoa-547-convert-sentryscreenframes-to…
itaybre 23ea86d
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/co…
itaybre 812c499
Fix comment order
itaybre 8432d30
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/co…
itaybre 030cc6e
Merge branch 'main' of github.com:getsentry/sentry-cocoa into itay/co…
itaybre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
Sources/Sentry/Profiling/SentryProfilingScreenFramesHelper.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#import "SentryDefines.h" | ||
#import <Foundation/Foundation.h> | ||
|
||
#if SENTRY_HAS_UIKIT | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
@class SentryScreenFrames; | ||
|
||
// Helper to use SentryScreenFrames without importing Swift on ObjC++ files. | ||
itaybre marked this conversation as resolved.
Show resolved
Hide resolved
|
||
@interface SentryProfilingScreenFramesHelper : NSObject | ||
+ (SentryScreenFrames *)copyScreenFrames:(SentryScreenFrames *)screenFrames; | ||
@end | ||
|
||
NS_ASSUME_NONNULL_END | ||
|
||
#endif // SENTRY_HAS_UIKIT |
15 changes: 15 additions & 0 deletions
15
Sources/Sentry/Profiling/SentryProfilingScreenFramesHelper.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#import "SentryProfilingScreenFramesHelper.h" | ||
#import "SentrySwift.h" | ||
|
||
#if SENTRY_HAS_UIKIT | ||
|
||
@implementation SentryProfilingScreenFramesHelper | ||
|
||
+ (SentryScreenFrames *)copyScreenFrames:(SentryScreenFrames *)screenFrames | ||
{ | ||
return [screenFrames copy]; | ||
} | ||
|
||
@end | ||
|
||
#endif // SENTRY_HAS_UIKIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.