chore: add fastlane code signing setup #5351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added .ruby-version file specifying Ruby 3.4.7. - Created Gemfile for performance tests with dependencies including fastlane, bigdecimal, logger, benchmark, mutex_m, abbrev, csv, and ostruct. - Updated Gemfile.lock to reflect new dependencies. - Added setup_code_signing lane in Fastfile for provisioning profiles in performance tests. - Updated Gemfile and Gemfile.lock in react-native sample to include abbrev, csv, and ostruct.
philprime
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93137d1+dirty | 367.58 ms | 434.94 ms | 67.36 ms |
| 170d5ea+dirty | 348.79 ms | 406.94 ms | 58.15 ms |
| 7091004+dirty | 377.76 ms | 402.11 ms | 24.35 ms |
| 3bd3f0d+dirty | 334.38 ms | 402.19 ms | 67.81 ms |
| af9331b+dirty | 374.42 ms | 425.68 ms | 51.26 ms |
| c1573b3+dirty | 355.65 ms | 448.82 ms | 93.17 ms |
| d1fd647+dirty | 374.46 ms | 409.51 ms | 35.05 ms |
| 8ece263+dirty | 369.44 ms | 414.65 ms | 45.21 ms |
| bfe454a+dirty | 372.42 ms | 424.52 ms | 52.10 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93137d1+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 170d5ea+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 7091004+dirty | 43.94 MiB | 48.81 MiB | 4.88 MiB |
| 3bd3f0d+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| af9331b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| c1573b3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| d1fd647+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 8ece263+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| bfe454a+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7091004+dirty | 1219.11 ms | 1225.98 ms | 6.87 ms |
| 526494a+dirty | 1220.96 ms | 1221.57 ms | 0.61 ms |
| 55b77fc+dirty | 1213.08 ms | 1218.19 ms | 5.11 ms |
| 90afdd3+dirty | 1216.17 ms | 1225.55 ms | 9.38 ms |
| 276d348+dirty | 1222.10 ms | 1229.02 ms | 6.92 ms |
| 20d5eaa+dirty | 1224.67 ms | 1223.16 ms | -1.51 ms |
| 2adbd1e+dirty | 1220.65 ms | 1230.20 ms | 9.56 ms |
| 23080e5+dirty | 1221.39 ms | 1222.08 ms | 0.70 ms |
| b7aa1aa+dirty | 1232.55 ms | 1234.16 ms | 1.61 ms |
| 6479fd5+dirty | 1207.80 ms | 1215.12 ms | 7.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7091004+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 526494a+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 55b77fc+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 90afdd3+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 276d348+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 20d5eaa+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 2adbd1e+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 23080e5+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| b7aa1aa+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| 6479fd5+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7091004+dirty | 1215.54 ms | 1215.58 ms | 0.04 ms |
| 526494a+dirty | 1210.20 ms | 1203.13 ms | -7.08 ms |
| 55b77fc+dirty | 1223.71 ms | 1224.12 ms | 0.41 ms |
| 90afdd3+dirty | 1233.90 ms | 1240.90 ms | 7.00 ms |
| 276d348+dirty | 1224.22 ms | 1227.38 ms | 3.16 ms |
| 20d5eaa+dirty | 1231.12 ms | 1226.00 ms | -5.12 ms |
| 2adbd1e+dirty | 1207.51 ms | 1218.98 ms | 11.47 ms |
| 23080e5+dirty | 1216.02 ms | 1224.94 ms | 8.91 ms |
| b7aa1aa+dirty | 1234.35 ms | 1241.61 ms | 7.27 ms |
| 6479fd5+dirty | 1228.48 ms | 1231.32 ms | 2.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7091004+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 526494a+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 55b77fc+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 90afdd3+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 276d348+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 20d5eaa+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 2adbd1e+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 23080e5+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| b7aa1aa+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| 6479fd5+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
While re-generating expired certificates and provisioning profiles I had to apply these changes to correctly set it up for the performance benchmark and sample apps.
#skip-changelog