feat: logsOrigin implementation #5354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
lucas-zimerman
changed the title
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98f632c | 424.25 ms | 435.48 ms | 11.23 ms |
| 459a438+dirty | 417.09 ms | 406.52 ms | -10.57 ms |
| ec14be7+dirty | 403.50 ms | 411.46 ms | 7.96 ms |
| 170d5ea+dirty | 407.92 ms | 422.49 ms | 14.57 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| c4e097a | 338.06 ms | 439.36 ms | 101.30 ms |
| 1226664+dirty | 347.45 ms | 386.60 ms | 39.15 ms |
| fa7bb7e+dirty | 350.37 ms | 377.02 ms | 26.65 ms |
| 8db9631+dirty | 442.78 ms | 461.96 ms | 19.18 ms |
| 20daa0a | 359.51 ms | 374.90 ms | 15.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98f632c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 459a438+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| ec14be7+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| 170d5ea+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| c4e097a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 1226664+dirty | 17.75 MiB | 19.74 MiB | 1.99 MiB |
| fa7bb7e+dirty | 17.75 MiB | 19.75 MiB | 2.00 MiB |
| 8db9631+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 20daa0a | 17.75 MiB | 20.15 MiB | 2.41 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93137d1+dirty | 1232.69 ms | 1245.18 ms | 12.49 ms |
| 7480abe+dirty | 1219.84 ms | 1223.60 ms | 3.76 ms |
| 2104bb9+dirty | 1221.63 ms | 1214.73 ms | -6.91 ms |
| 90edad7+dirty | 1235.21 ms | 1241.45 ms | 6.24 ms |
| 0b64753+dirty | 1225.77 ms | 1232.98 ms | 7.21 ms |
| b7aa1aa+dirty | 1232.55 ms | 1234.16 ms | 1.61 ms |
| 000da7a+dirty | 1204.50 ms | 1218.94 ms | 14.44 ms |
| e07935d+dirty | 1225.85 ms | 1227.72 ms | 1.87 ms |
| 69602ce+dirty | 1230.59 ms | 1230.84 ms | 0.24 ms |
| 6479fd5+dirty | 1207.80 ms | 1215.12 ms | 7.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93137d1+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 7480abe+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 2104bb9+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| 90edad7+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 0b64753+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| b7aa1aa+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| 000da7a+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| e07935d+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 69602ce+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 6479fd5+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93137d1+dirty | 1230.73 ms | 1230.98 ms | 0.25 ms |
| 7480abe+dirty | 1220.53 ms | 1244.18 ms | 23.65 ms |
| 2104bb9+dirty | 1222.94 ms | 1221.16 ms | -1.77 ms |
| 90edad7+dirty | 1222.08 ms | 1228.40 ms | 6.32 ms |
| 0b64753+dirty | 1232.49 ms | 1226.96 ms | -5.53 ms |
| b7aa1aa+dirty | 1234.35 ms | 1241.61 ms | 7.27 ms |
| 000da7a+dirty | 1214.31 ms | 1221.91 ms | 7.61 ms |
| e07935d+dirty | 1217.37 ms | 1211.44 ms | -5.93 ms |
| 69602ce+dirty | 1235.65 ms | 1230.82 ms | -4.83 ms |
| 6479fd5+dirty | 1228.48 ms | 1231.32 ms | 2.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93137d1+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 7480abe+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 2104bb9+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| 90edad7+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 0b64753+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| b7aa1aa+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| 000da7a+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| e07935d+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 69602ce+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 6479fd5+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
antonis
reviewed
Nov 11, 2025
antonis
reviewed
Nov 11, 2025
antonis
reviewed
Nov 11, 2025
antonis
reviewed
Nov 11, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
Thank you for adding this @lucas-zimerman 🙇
I've added a few comments but overall the implementation LGTM!
Thank you for adding extensive test cases 🚀
Co-authored-by: Antonis Lilis <[email protected]>
antonis
approved these changes
Nov 11, 2025
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4e097a+dirty | 382.43 ms | 443.77 ms | 61.34 ms |
| 5526494+dirty | 380.79 ms | 432.70 ms | 51.91 ms |
| 59f3a84+dirty | 359.69 ms | 407.54 ms | 47.86 ms |
| 90edad7+dirty | 372.57 ms | 398.83 ms | 26.26 ms |
| 07808fb+dirty | 392.47 ms | 451.94 ms | 59.47 ms |
| 2104bb9+dirty | 313.00 ms | 309.76 ms | -3.24 ms |
| 98f632c+dirty | 323.98 ms | 375.39 ms | 51.41 ms |
| 8db9631+dirty | 351.44 ms | 396.28 ms | 44.84 ms |
| 20d5eaa+dirty | 358.31 ms | 442.37 ms | 84.06 ms |
| 170d5ea+dirty | 348.79 ms | 406.94 ms | 58.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4e097a+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 5526494+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 59f3a84+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 90edad7+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 07808fb+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 2104bb9+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| 98f632c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 8db9631+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 20d5eaa+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 170d5ea+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Before this change, users couldn't opt out for which layers they don't want logs, JavaScript and Native both produces logs that may or may not be interesting to their use.
💡 Motivation and Context
The changes allows users to choose between
all,jsand `native. As the name implies you can choose if only JavaScript, Native or both will be allowed to create logs.💚 How did you test it?
Simulator, Tests.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps