Skip to content

Ref: Use danger to check ready-for-merge label #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 12, 2025
Merged

Ref: Use danger to check ready-for-merge label #5366

merged 9 commits into from
Nov 12, 2025

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Nov 12, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

  • Allows danger to warn when the ready-form-merge flag is missing.
  • Make danger react to label changes.

💡 Motivation and Context

Danger had a label feature that you can skip the changelog, which didnt worked since there was no reactions to label changes.
And since we are using the ready-to-merge label to block CI, it wont hurt to warn developers that the flag is required.

💚 How did you test it?

image

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@lucas-zimerman lucas-zimerman changed the title Ref: Use danger to check ready-for-merge label (NOT READY FOR REVIEW!) Ref: Use danger to check ready-for-merge label Nov 12, 2025
@lucas-zimerman lucas-zimerman marked this pull request as ready for review November 12, 2025 10:21
@lucas-zimerman lucas-zimerman changed the title (NOT READY FOR REVIEW!) Ref: Use danger to check ready-for-merge label (NOT READY FOR REVIEW!) Ref: Use danger to check ready-for-merge label . Nov 12, 2025
@lucas-zimerman lucas-zimerman changed the title (NOT READY FOR REVIEW!) Ref: Use danger to check ready-for-merge label . (NOT READY FOR REVIEW!) Ref: Use danger to check ready-for-merge label Nov 12, 2025
@lucas-zimerman lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Nov 12, 2025
@lucas-zimerman lucas-zimerman removed the ready-to-merge Triggers the full CI test suite label Nov 12, 2025
@lucas-zimerman lucas-zimerman changed the title (NOT READY FOR REVIEW!) Ref: Use danger to check ready-for-merge label Ref: Use danger to check ready-for-merge label Nov 12, 2025
@lucas-zimerman lucas-zimerman added skip-changelog ready-to-merge Triggers the full CI test suite CI and removed skip-changelog labels Nov 12, 2025
@lucas-zimerman
Copy link
Collaborator Author

lucas-zimerman commented Nov 12, 2025

@antonis @alwx Now it's ready to merge :D

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 358.81 ms 394.94 ms 36.13 ms
Size 43.94 MiB 48.82 MiB 4.88 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
459a438+dirty 359.50 ms 390.53 ms 31.03 ms
ec14be7+dirty 401.58 ms 475.26 ms 73.68 ms
46da307+dirty 356.62 ms 415.02 ms 58.40 ms
55b77fc+dirty 410.46 ms 414.11 ms 3.65 ms
170d5ea+dirty 348.79 ms 406.94 ms 58.15 ms
c7f264b+dirty 356.98 ms 407.46 ms 50.48 ms
785ffb1+dirty 380.65 ms 451.83 ms 71.18 ms
1226664+dirty 377.65 ms 453.94 ms 76.29 ms
c4e097a+dirty 382.43 ms 443.77 ms 61.34 ms
5526494+dirty 380.79 ms 432.70 ms 51.91 ms

App size

Revision Plain With Sentry Diff
459a438+dirty 7.15 MiB 8.42 MiB 1.27 MiB
ec14be7+dirty 7.15 MiB 8.42 MiB 1.26 MiB
46da307+dirty 7.15 MiB 8.41 MiB 1.26 MiB
55b77fc+dirty 43.94 MiB 48.82 MiB 4.88 MiB
170d5ea+dirty 7.15 MiB 8.42 MiB 1.27 MiB
c7f264b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
785ffb1+dirty 7.15 MiB 8.42 MiB 1.27 MiB
1226664+dirty 7.15 MiB 8.46 MiB 1.30 MiB
c4e097a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
5526494+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 383.46 ms 406.56 ms 23.10 ms
Size 43.75 MiB 47.99 MiB 4.24 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
07808fb+dirty 419.10 ms 419.08 ms -0.02 ms
88890fe+dirty 350.94 ms 365.74 ms 14.80 ms
d916aa3 425.37 ms 427.02 ms 1.65 ms
c9e95bd 428.04 ms 458.70 ms 30.65 ms
55b77fc+dirty 411.87 ms 417.16 ms 5.29 ms
98f632c 424.25 ms 435.48 ms 11.23 ms
4604da9+dirty 366.44 ms 398.10 ms 31.66 ms
170d5ea+dirty 407.92 ms 422.49 ms 14.57 ms
eb07ba3 470.04 ms 473.35 ms 3.31 ms
05bef0e+dirty 349.78 ms 334.04 ms -15.74 ms

App size

Revision Plain With Sentry Diff
07808fb+dirty 17.75 MiB 19.70 MiB 1.95 MiB
88890fe+dirty 17.75 MiB 19.71 MiB 1.96 MiB
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
c9e95bd 17.75 MiB 19.68 MiB 1.93 MiB
55b77fc+dirty 43.75 MiB 47.99 MiB 4.24 MiB
98f632c 17.75 MiB 20.15 MiB 2.41 MiB
4604da9+dirty 17.75 MiB 19.74 MiB 2.00 MiB
170d5ea+dirty 17.75 MiB 19.70 MiB 1.95 MiB
eb07ba3 17.75 MiB 20.15 MiB 2.41 MiB
05bef0e+dirty 17.75 MiB 19.70 MiB 1.95 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.89 ms 1223.68 ms 3.79 ms
Size 3.41 MiB 4.58 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
170d5ea+dirty 1233.96 ms 1242.54 ms 8.58 ms
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms
20daa0a+dirty 1227.71 ms 1233.72 ms 6.01 ms
c94a927+dirty 1211.33 ms 1223.31 ms 11.97 ms
d1fd647+dirty 1218.16 ms 1225.82 ms 7.65 ms
46e3d54+dirty 1213.17 ms 1216.33 ms 3.17 ms
46bd012+dirty 1231.78 ms 1212.30 ms -19.47 ms
6fee48d+dirty 1208.85 ms 1218.52 ms 9.67 ms
5526494+dirty 1217.06 ms 1222.26 ms 5.20 ms
0b64753+dirty 1225.77 ms 1232.98 ms 7.21 ms

App size

Revision Plain With Sentry Diff
170d5ea+dirty 3.19 MiB 4.55 MiB 1.36 MiB
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB
20daa0a+dirty 3.19 MiB 4.38 MiB 1.19 MiB
c94a927+dirty 3.19 MiB 4.56 MiB 1.37 MiB
d1fd647+dirty 3.19 MiB 4.56 MiB 1.37 MiB
46e3d54+dirty 3.41 MiB 4.58 MiB 1.17 MiB
46bd012+dirty 3.19 MiB 4.38 MiB 1.19 MiB
6fee48d+dirty 3.19 MiB 4.53 MiB 1.35 MiB
5526494+dirty 3.19 MiB 4.44 MiB 1.25 MiB
0b64753+dirty 3.19 MiB 4.55 MiB 1.36 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.36 ms 1216.20 ms -6.16 ms
Size 3.41 MiB 4.58 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
170d5ea+dirty 1219.27 ms 1231.90 ms 12.63 ms
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
20daa0a+dirty 1233.12 ms 1233.35 ms 0.22 ms
c94a927+dirty 1227.14 ms 1239.64 ms 12.50 ms
d1fd647+dirty 1219.35 ms 1233.18 ms 13.83 ms
46e3d54+dirty 1216.40 ms 1210.47 ms -5.93 ms
46bd012+dirty 1220.49 ms 1226.89 ms 6.40 ms
6fee48d+dirty 1222.14 ms 1231.44 ms 9.30 ms
5526494+dirty 1224.73 ms 1229.08 ms 4.36 ms
0b64753+dirty 1232.49 ms 1226.96 ms -5.53 ms

App size

Revision Plain With Sentry Diff
170d5ea+dirty 2.63 MiB 3.98 MiB 1.35 MiB
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
20daa0a+dirty 2.63 MiB 3.81 MiB 1.18 MiB
c94a927+dirty 2.63 MiB 3.99 MiB 1.36 MiB
d1fd647+dirty 2.63 MiB 3.99 MiB 1.36 MiB
46e3d54+dirty 3.41 MiB 4.58 MiB 1.17 MiB
46bd012+dirty 2.63 MiB 3.81 MiB 1.18 MiB
6fee48d+dirty 2.63 MiB 3.96 MiB 1.33 MiB
5526494+dirty 2.63 MiB 3.87 MiB 1.24 MiB
0b64753+dirty 2.63 MiB 3.98 MiB 1.35 MiB

antonis
antonis approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸
Thank you for enhancing our tooling Lucas 🦸

@lucas-zimerman lucas-zimerman merged commit c771b48 into main Nov 12, 2025
76 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/check-label branch November 12, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonis antonis antonis approved these changes

@alwx alwx Awaiting requested review from alwx alwx is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman @antonis