Skip to content

Enforce latest rubygems on CI #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 1 commit into from
Oct 20, 2024
Merged

Enforce latest rubygems on CI #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/sentry_delayed_job_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
rubygems: latest
bundler-cache: true

- name: Run specs
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_opentelemetry_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
rubygems: latest
bundler-cache: true

- name: Run specs
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_rails_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
rubygems: latest
bundler-cache: true

- name: Build with Rails ${{ matrix.rails_version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_resque_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
rubygems: latest
bundler-cache: true

- name: Start Redis
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_ruby_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
rubygems: latest
bundler-cache: true

- name: Start Redis
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/sentry_sidekiq_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- { ruby_version: 2.6, sidekiq_version: 5.0 }
- { ruby_version: 2.6, sidekiq_version: 6.0 }
- { ruby_version: jruby, sidekiq_version: 5.0 }
- { ruby_version: jruby, sidekiq_version: 6.0 }
- { ruby_version: jruby, sidekiq_version: 6.5 }
Copy link
Collaborator Author

@solnic solnic Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With latest rubygems under jruby, bundling sidekiq using 6.0 as the version spec would install sidekiq 6.0.x - and that version actually crashes with Sidekiq[]= not being defined error.

- { ruby_version: jruby, sidekiq_version: 7.0 }
- {
ruby_version: "3.2",
Expand All @@ -57,6 +57,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
rubygems: latest
bundler-cache: true

- name: Start Redis
Expand Down
2 changes: 2 additions & 0 deletions sentry-sidekiq/spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
rescue LoadError
end

require "sidekiq"

# this enables sidekiq's server mode
require "sidekiq/cli"

Expand Down