Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Jan 2, 2025

This fixes "unexpected end of the stream within a flow collection" error that we started seeing. Not sure what changed on GH though.

#skip-changelog

This fixes "unexpected end of the stream within a flow collection" error
that we started seeing. Not sure what changed on GH though.
@solnic solnic requested review from sl0thentr0py and st0012 January 2, 2025 12:25
@codecov
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (bf8d8c5) to head (02bb1de).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2507   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         128      128           
  Lines        4837     4839    +2     
=======================================
+ Hits         4749     4751    +2     
  Misses         88       88           
Components Coverage Δ
sentry-ruby 98.57% <100.00%> (ø)
sentry-rails 97.07% <100.00%> (+0.15%) ⬆️
sentry-sidekiq 97.02% <ø> (-0.41%) ⬇️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)

see 2 files with indirect coverage changes

@solnic solnic marked this pull request as ready for review January 2, 2025 12:36
Copy link
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do prefer this style better, I've never seen the said error before. Is there any example build that failed with it?

@solnic
Copy link
Collaborator Author

solnic commented Jan 7, 2025

While I do prefer this style better, I've never seen the said error before. Is there any example build that failed with it?

So, here's a funny story - after I merged a PR that added 3.4 to the matrix last week, builds stopped working. I looked at the workflow yml in GH UI and it showed me the error, so I thought something changed on GH and it breaks now due to this syntax error...and then it just magically started working again.

We could merge this in regardless, it's simpler syntax after all.

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sl0thentr0py sl0thentr0py merged commit a1d2941 into master Jan 9, 2025
149 of 150 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/fix-workflows-syntax branch January 9, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants