Skip to content

Conversation

@sanfrecce-osaka
Copy link
Contributor

@sanfrecce-osaka sanfrecce-osaka commented May 24, 2025

Description

Now, default rails version in sentry-rails is 8.0.

cf. https://github.com/getsentry/sentry-ruby/blob/5.24.0/sentry-rails/Gemfile#L20

But written on CONTRIBUTING.md is 7.0. So I fixed it.

#skip-changelog

Now, default rails version in sentry-rails is `8.0`.

cf. https://github.com/getsentry/sentry-ruby/blob/5.24.0/sentry-rails/Gemfile#L20

But written on CONTRIBUTING.md is `7.0`. So I fixed it.
@solnic solnic self-requested a review May 27, 2025 15:14
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! <3

@solnic solnic merged commit 62ca431 into getsentry:master May 27, 2025
112 of 136 checks passed
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (90d5a3a) to head (fd8203c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2636      +/-   ##
==========================================
- Coverage   96.13%   94.90%   -1.24%     
==========================================
  Files         133      133              
  Lines        5123     5100      -23     
==========================================
- Hits         4925     4840      -85     
- Misses        198      260      +62     
Components Coverage Δ
sentry-ruby 94.92% <ø> (-2.48%) ⬇️
sentry-rails 94.31% <ø> (-0.60%) ⬇️
sentry-sidekiq 93.84% <ø> (+13.76%) ⬆️
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (+0.68%) ⬆️

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants