-
-
Notifications
You must be signed in to change notification settings - Fork 523
Logger support #2657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger support #2657
Conversation
…ruby into stdlib-logger-support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
+ Coverage 96.98% 97.48% +0.49%
==========================================
Files 133 134 +1
Lines 5147 5167 +20
==========================================
+ Hits 4992 5037 +45
+ Misses 155 130 -25
🚀 New features to boost your workflow:
|
|
OK I need to rework this because there are issues with the spec suite as testing is not isolated and patching obviously changes runtime. Right now it gets to a state that would normally be very unlikely to have where the patch is applied but |
cca089a to
0121c8c
Compare
|
@sl0thentr0py ignore head failures, something is messed up with bundling rn 🤷🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also needs a SimpleCov.command_name since it is now isolated
This builds on #2653.
I had to isolate specs because we can't patch logger while running the whole spec suite.
#skip-changelog