Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Jun 26, 2025

This adds tests for Rails.logger when :logger patch is enabled. I also add a unified way of defining spec tasks for our projects so that I can easily add an isolated spec to sentry-rails.

Refs #2644

#skip-changelog

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (eeaeb2a) to head (b3fed53).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2659      +/-   ##
==========================================
- Coverage   97.48%   94.09%   -3.39%     
==========================================
  Files         134      134              
  Lines        5167     5135      -32     
==========================================
- Hits         5037     4832     -205     
- Misses        130      303     +173     
Components Coverage Δ
sentry-ruby 93.53% <ø> (-4.20%) ⬇️
sentry-rails 96.55% <ø> (-0.15%) ⬇️
sentry-sidekiq 94.23% <ø> (-2.35%) ⬇️
sentry-resque 91.66% <ø> (-2.78%) ⬇️
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 98.61% <ø> (-0.70%) ⬇️

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic solnic marked this pull request as ready for review June 26, 2025 09:45
@solnic solnic requested review from sl0thentr0py June 26, 2025 09:46
@solnic
Copy link
Collaborator Author

solnic commented Jun 26, 2025

@sl0thentr0py no idea what's going on with ruby head yet so pls ignore it again 🙃

@solnic solnic force-pushed the logger-patch-with-rails branch from 8c1d65f to b3fed53 Compare June 26, 2025 11:55
@solnic
Copy link
Collaborator Author

solnic commented Jun 26, 2025

@sl0thentr0py OK I moved the rake tasks stuff to the toplevel

@solnic solnic merged commit 1e377d6 into master Jun 26, 2025
257 of 268 checks passed
@solnic solnic deleted the logger-patch-with-rails branch June 26, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants