Skip to content

Fix flaky faraday spec #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 1 commit into from
Jul 29, 2025
Merged

Fix flaky faraday spec #2666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sentry-ruby/spec/sentry/faraday_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# frozen_string_literal: true

require "faraday"
require "contexts/with_request_mock"

require_relative "../spec_helper"

RSpec.describe Sentry::Faraday do
Expand Down Expand Up @@ -263,6 +265,8 @@
end

context "when adapter is net/http" do
include_context "with request mock"

let(:http) do
Faraday.new(url) do |f|
f.request :json
Expand All @@ -272,7 +276,9 @@

let(:url) { "http://example.com" }

it "skips instrumentation", webmock: false do
it "skips instrumentation" do
stub_normal_response(code: "200")

transaction = Sentry.start_transaction
Sentry.get_current_scope.set_span(transaction)

Expand Down
Loading