Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Aug 26, 2025

This adds an abstract Sentry::Rails::LogSubscriber along with a common extension for parameter filtering Sentry::Rails::LogSubscribers::ParemeterFilter

Refs #2605

@solnic solnic force-pushed the 2605-rails-structured-log-subscriber branch from df35662 to 98e05b3 Compare August 26, 2025 15:37
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 95.78947% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.42%. Comparing base (337a4ca) to head (443441a).

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/configuration.rb 50.00% 3 Missing ⚠️
sentry-ruby/lib/sentry-ruby.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   97.44%   97.42%   -0.02%     
==========================================
  Files         136      139       +3     
  Lines        5317     5408      +91     
==========================================
+ Hits         5181     5269      +88     
- Misses        136      139       +3     
Components Coverage Δ
sentry-ruby 97.74% <93.54%> (-0.02%) ⬇️
sentry-rails 96.14% <100.00%> (+0.04%) ⬆️
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/log_subscriber.rb 100.00% <100.00%> (ø)
...b/sentry/rails/log_subscribers/parameter_filter.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/debug_structured_logger.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/test_helper.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry-ruby.rb 98.73% <75.00%> (-0.41%) ⬇️
sentry-ruby/lib/sentry/configuration.rb 97.42% <50.00%> (-0.94%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic solnic force-pushed the 2605-rails-structured-log-subscriber branch from 98e05b3 to 9e4146e Compare August 26, 2025 20:38
@solnic solnic force-pushed the 2605-rails-structured-log-subscriber branch from 9e4146e to 443441a Compare August 26, 2025 20:39
@solnic solnic closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants