Skip to content

Rails active support log subscribers #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 21 commits into from
Sep 3, 2025

More coverage

b87ad68
Select commit
Loading
Failed to load commit list.
Merged

Rails active support log subscribers #2690

More coverage
b87ad68
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 3, 2025 in 1s

97.25% (-0.19%) compared to 337a4ca

View this Pull Request on Codecov

97.25% (-0.19%) compared to 337a4ca

Details

Codecov Report

❌ Patch coverage is 93.92097% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.25%. Comparing base (337a4ca) to head (b87ad68).

Files with missing lines Patch % Lines
...try/rails/log_subscribers/active_job_subscriber.rb 89.09% 6 Missing ⚠️
.../rails/log_subscribers/active_record_subscriber.rb 95.00% 3 Missing ⚠️
sentry-ruby/lib/sentry/configuration.rb 50.00% 3 Missing ⚠️
...ls/log_subscribers/action_controller_subscriber.rb 96.07% 2 Missing ⚠️
...entry-rails/lib/sentry/rails/structured_logging.rb 88.88% 2 Missing ⚠️
sentry-ruby/lib/sentry/test_helper.rb 77.77% 2 Missing ⚠️
.../rails/log_subscribers/action_mailer_subscriber.rb 96.77% 1 Missing ⚠️
sentry-ruby/lib/sentry-ruby.rb 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2690      +/-   ##
==========================================
- Coverage   97.44%   97.25%   -0.19%     
==========================================
  Files         136      144       +8     
  Lines        5317     5642     +325     
==========================================
+ Hits         5181     5487     +306     
- Misses        136      155      +19
Components Coverage Δ
sentry-ruby 97.70% <90.62%> (-0.07%) ⬇️
sentry-rails 95.60% <94.71%> (-0.51%) ⬇️
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/log_subscriber.rb 100.00% <100.00%> (ø)
...b/sentry/rails/log_subscribers/parameter_filter.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/railtie.rb 98.83% <100.00%> (+0.05%) ⬆️
sentry-ruby/lib/sentry/debug_structured_logger.rb 100.00% <100.00%> (ø)
.../rails/log_subscribers/action_mailer_subscriber.rb 96.77% <96.77%> (ø)
sentry-ruby/lib/sentry-ruby.rb 98.73% <75.00%> (-0.41%) ⬇️
...ls/log_subscribers/action_controller_subscriber.rb 96.07% <96.07%> (ø)
...entry-rails/lib/sentry/rails/structured_logging.rb 88.88% <88.88%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov