Skip to content

Change default Stackprof profiler interval to 1000 microseconds #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nateberkopec wants to merge 3 commits into from
Closed

Change default Stackprof profiler interval to 1000 microseconds #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcbfa8a
Change default profiler interval to 1000 microseconds
nateberkopec Oct 8, 2025
b62d5fd
Changelog/test
nateberkopec Oct 8, 2025
f512bd9
Not clear to me how to actually run the tests so I'm gonna go with wh…
nateberkopec Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Unreleased

- Change default Stackprof profiler interval to 1000 microseconds ([#2742](https://github.com/getsentry/sentry-ruby/pull/2742))

## 5.28.0

### Features
Expand All @@ -7,7 +11,7 @@
### Miscellaneous

- Deprecate all Metrics related APIs [#2726](https://github.com/getsentry/sentry-ruby/pull/2726)

Sentry [no longer has the Metrics Beta offering](https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th) so
all the following APIs linked to Metrics have been deprecated and will be removed in the next major.

Expand Down
4 changes: 2 additions & 2 deletions sentry-ruby/lib/sentry/profiler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class Profiler

VERSION = "1"
PLATFORM = "ruby"
# 101 Hz in microseconds
DEFAULT_INTERVAL = 1e6 / 101
# 1000 Hz in microseconds
DEFAULT_INTERVAL = 1000
MICRO_TO_NANO_SECONDS = 1e3
MIN_SAMPLES_REQUIRED = 2

Expand Down
2 changes: 1 addition & 1 deletion sentry-ruby/spec/sentry/profiler_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
subject.set_initial_sample_decision(true)

expect(StackProf).to receive(:start).with(
interval: 1e6 / 101,
interval: 1000,
mode: :wall,
raw: true,
aggregate: false
Expand Down
Loading