chore(rails): remove 5.0 leftovers

[solnic]

#skip-changelog

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (f951c95) to head (cf8ee0b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2760   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files         130      130           
  Lines        5229     5229           
=======================================
  Hits         5085     5085           
  Misses        144      144           

Components	Coverage Δ
sentry-ruby	97.54% <ø> (ø)
sentry-rails	96.74% <ø> (ø)
sentry-sidekiq	95.05% <ø> (ø)
sentry-resque	94.44% <ø> (ø)
sentry-delayed_job	94.68% <ø> (ø)
sentry-opentelemetry	99.31% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cursor]

Bug: Rails Version Compatibility Issue

The FILE_NAME case statement now returns nil for Rails versions below 5.2. Using this nil in require statements creates malformed paths, leading to LoadError exceptions. The resulting LoadError messages are unclear, not explicitly indicating an unsupported Rails version.

sentry-rails/spec/dummy/test_rails_app/app.rb#L25-L38

sentry-ruby/sentry-rails/spec/dummy/test_rails_app/app.rb

Lines 25 to 38 in cf8ee0b

	FILE_NAME =
	case Gem::Version.new(Rails.version)
	when ->(v) { v.between?(v5_2, v6_0) }
	"5-2"
	when ->(v) { v.between?(v6_0, v6_1) }
	"6-0"
	when ->(v) { v.between?(v6_1, v7_0) }
	"6-1"
	when ->(v) { v > v7_0 && v < v7_1 }
	"7-0"
	when ->(v) { v >= v7_1 }
	"7-1"
	end

 

---

[sentry]

Bug: Rails 7.0.0 incorrectly loads 6-1.rb config due to Gem::Version.between?'s inclusive upper bound, missing 7-0.rb specific configurations.
_{Severity: CRITICAL | Confidence: 1.00}

🔍 Detailed Analysis

When running with Rails 7.0.0, the version selection logic incorrectly matches v.between?(v6_1, v7_0) because Gem::Version.between? is inclusive of both endpoints. This causes the application to load configs/6-1.rb and apps/6-1.rb instead of the correct 7-0.rb files. Consequently, Rails 7.0-specific configurations, such as Zeitwerk::Registry.loaders.clear, are not loaded, leading to incorrect application behavior or test failures.

💡 Suggested Fix

Adjust the version comparison for Rails 7.0.0. Either modify v.between?(v6_1, v7_0) to exclude the upper bound (e.g., v.between?(v6_1, Gem::Version.new("6.999.999"))) or change the subsequent condition to v >= v7_0 && v < v7_1.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: sentry-rails/spec/dummy/test_rails_app/app.rb#L27-L30

Potential issue: When running with Rails 7.0.0, the version selection logic incorrectly
matches `v.between?(v6_1, v7_0)` because `Gem::Version.between?` is inclusive of both
endpoints. This causes the application to load `configs/6-1.rb` and `apps/6-1.rb`
instead of the correct `7-0.rb` files. Consequently, Rails 7.0-specific configurations,
such as `Zeitwerk::Registry.loaders.clear`, are not loaded, leading to incorrect
application behavior or test failures.

_{Did we get this right? 👍 / 👎 to inform future reviews.}