Skip to content

Small clean up in client spec #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 2 commits into from
Nov 17, 2025
Merged

Small clean up in client spec #2778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cffd5a
chore(specs): minor formatting fix
solnic Nov 17, 2025
cdf4d28
fix(specs): remove global class from client spec
solnic Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions sentry-ruby/spec/sentry/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
# frozen_string_literal: true

class ExceptionWithContext < StandardError
def sentry_context
{
foo: "bar"
}
end
end

RSpec.describe Sentry::Client do
subject { Sentry::Client.new(configuration) }

let(:configuration) do
Sentry::Configuration.new.tap do |config|
config.dsn = Sentry::TestHelper::DUMMY_DSN
config.transport.transport_class = Sentry::DummyTransport
end
end
subject { Sentry::Client.new(configuration) }

let(:hub) do
Sentry::Hub.new(subject, Sentry::Scope.new)
Expand Down Expand Up @@ -571,8 +564,18 @@ module ExcTag; end
end

context 'when the exception responds to sentry_context' do
let(:exception_with_context) do
Class.new(StandardError) do
def sentry_context
{
foo: "bar"
}
end
end
end

let(:hash) do
event = subject.event_from_exception(ExceptionWithContext.new)
event = subject.event_from_exception(exception_with_context.new)
event.to_h
end

Expand Down
Loading