Skip to content

chore(devcontainer): use node from features + update images #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 2 commits into from
Jan 9, 2026
+14 −18
Merged

chore(devcontainer): use node from features + update images #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29de45d
chore(devcontainer): use node from features
solnic Jan 9, 2026
0c9231c
chore(devcontainer): add 4.0 and update the rest
solnic Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

RUN curl -fsSL https://deb.nodesource.com/setup_22.x | bash -
Copy link

@cursor cursor bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chromium removed from Dockerfile breaks e2e tests

High Severity

The Dockerfile previously installed chromium and chromium-driver via apt-get, which are required by the Selenium-based e2e tests. These packages were removed but not replaced with a devcontainer feature. The test suite in spec/spec_helper.rb explicitly configures Capybara to use selenium_headless_chrome and references /usr/bin/chromium as the browser binary. The e2e tests will fail because Chromium is no longer available in the container.

Fix in Cursor Fix in Web

Copy link
Collaborator Author

@solnic solnic Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it does not. We install them in the action.


RUN apt-get update && apt-get install -y --no-install-recommends \
nodejs \
chromium \
chromium-driver \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

RUN echo "sentry ALL=(ALL) NOPASSWD:ALL" > /etc/sudoers.d/sentry \
&& chmod 0440 /etc/sudoers.d/sentry

Expand Down
7 changes: 3 additions & 4 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@
"features": {
"ghcr.io/devcontainers/features/github-cli": {},
"ghcr.io/nils-geistmann/devcontainers-features/zsh": {},
"ghcr.io/devcontainers/features/node:1": {},
"ghcr.io/devcontainers-extra/features/npm-packages": {},
"ghcr.io/devcontainers/features/copilot-cli:1": {},
"ghcr.io/rocker-org/devcontainer-features/apt-packages": {
"packages": "inotify-tools"
}
},
"customizations": {
"vscode": {
"extensions": [
"sleistner.vscode-fileutils",
"Shopify.ruby-lsp"
],
"extensions": ["sleistner.vscode-fileutils", "Shopify.ruby-lsp"],
"editor.formatOnSaveMode": "modifications",
"editor.formatOnSave": true,
"rubyLsp.rubyVersionManager": {
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/build_images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ jobs:
- ruby:2.7.8-slim-bullseye
- ruby:3.0.7-slim-bullseye
- ruby:3.1.7-slim-bookworm
- ruby:3.2.9-slim-bookworm
- ruby:3.3.9-slim-bookworm
- ruby:3.4.5-slim-bookworm
- ruby:3.2.9-slim-trixie
- ruby:3.3.10-slim-trixie
- ruby:3.4.8-slim-trixie
- ruby:4.0.0-slim-trixie

steps:
- name: Check out current commit
Expand Down Expand Up @@ -67,8 +68,8 @@ jobs:
id: build
uses: getsentry/action-build-and-push-images@main
with:
image_name: '${{ steps.image_name.outputs.short_name }}'
dockerfile_path: '.devcontainer/Dockerfile'
image_name: "${{ steps.image_name.outputs.short_name }}"
dockerfile_path: ".devcontainer/Dockerfile"
ghcr: true
publish_on_pr: true
build_args: |
Expand Down
5 changes: 5 additions & 0 deletions spec/apps/svelte-mini/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading