Unify LogEventBuffer and MetricEventBuffer logic #2830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
commented
Jan 12, 2026
| case type | ||
| when "session", "attachment", "transaction", "profile", "span", "log", "trace_metric" then type | ||
| when "session", "attachment", "transaction", "profile", "span", "trace_metric" then type | ||
| when "log" then "log_item" |
Member
Author
There was a problem hiding this comment.
log data_category was wrong here
sl0thentr0py
force-pushed
the
neel/metrics-buffer-unification
branch
from
7980187 to
9680abf
Compare
sl0thentr0py
force-pushed
the
neel/metrics-buffer-unification
branch
from
9680abf to
5aeb880
Compare
solnic
requested changes
Jan 12, 2026
Collaborator
solnic
left a comment
solnic
left a comment
There was a problem hiding this comment.
only needs a few small debug logging related fixes, otherwise 👏🏻 👏🏻 👏🏻
Co-authored-by: Peter Solnica <[email protected]>
Co-authored-by: Peter Solnica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TelemetryEventBufferclassIssues